oppia Fix #20567: Pointer on the close dropdown of a card in Goals tab of Learner dashboard

Overview

This PR fixes or fixes part of #20561.
This PR does the following: Pointer on the close dropdown of a card in Goals tab of Learner dashboard

Essential Checklist

Please follow the instructions for making a code change.

[x] I have linked the issue that this PR fixes in the "Development" section of the sidebar.
[x] I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
[x] I have written tests for my code.
[x] The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
[x] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

https://drive.google.com/file/d/1RukcTE7AfhjUVVu42N5HdDfLI-hEqPQX/view?usp=sharing

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

Jun 25 '24 09:06 mannika763

Hi @mannika763, can you complete the following:

The proof that changes are correct has not been provided, please make sure to upload a image/video showing that the changes are correct. Or include a sentence saying "No proof of changes needed because" and the reason why proof of changes cannot be provided. Thanks!

Jun 25 '24 09:06 oppiabot[bot]

Assigning @kevintab95 for the first pass review of this PR. Thanks!

Jun 25 '24 09:06 oppiabot[bot]

Hi @mannika763 , Could you please address the lint tests failing on your PR by the time reviewers review your changes - https://github.com/oppia/oppia/actions/runs/9659956253/job/26644439685?pr=20567#step:8:1801

(Wondering how this code managed to bypass the pre-push lint checks)

Also please follow the 4th point of the Essential checklist in the PR description above.

Thanks!

Jun 25 '24 12:06 AkashPaloju

Hi @AkashPaloju, Thankyou for letting me know. I have addressed the issue of the lint tests failing and also updated the 4th point of the Essential Checklist in the PR description.

Jun 25 '24 15:06 mannika763

Hi @AkashPaloju, Thankyou for letting me know. I have addressed the issue of the lint tests failing and also updated the 4th point of the Essential Checklist in the PR description.

@mannika763 I meant to change the PR title by following the instructions given in 4th point earlier ( but you have changed the 4th point itself, please revert it back). See this example PR title. Hope you got it. Thanks!

Jun 25 '24 16:06 AkashPaloju

Okay, I have changed it. Is that okay now?

Jun 25 '24 16:06 mannika763

Hi @mannika763, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

Jul 02 '24 17:07 oppiabot[bot]

Hi @AkashPaloju i am little confused here. could you tell me what is the issue here?

Jul 06 '24 17:07 mannika763

@mannika763 If reviewers take more than 2-3 days to review, you should remind them by leaving a comment in the PR thread saying, "Hi @username, friendly reminder to review this PR." Otherwise, if there is no activity in the PR for 7 days, the oppiabot will label it as "stale."

Thanks!

( Update this branch )

Jul 06 '24 17:07 AkashPaloju

Hi @kevintab95 I hope you are well. This is just a gentle reminder to review my PR.

Jul 07 '24 05:07 mannika763

Hi @mannika763, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

Jul 14 '24 06:07 oppiabot[bot]

Hi @kevintab95,

I hope you are well. I just wanted to kindly remind you to review this PR whenever you have a moment.

Thank you!

Jul 16 '24 15:07 mannika763

Hi @mannika763, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

Jul 23 '24 16:07 oppiabot[bot]

Hey @kevintab95 Np.

I have made another pull request. Could you please take a look at #20789 and let me know if any changes are still needed?

Aug 09 '24 07:08 mannika763

Unassigning @mannika763 since a re-review was requested. @mannika763, please make sure you have addressed all review comments. Thanks!

Aug 09 '24 07:08 oppiabot[bot]

Hi @mannika763, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

Aug 16 '24 08:08 oppiabot[bot]