oppia icon indicating copy to clipboard operation
oppia copied to clipboard

Fix part of #19435: Migrate topics and skills dashboard and creator dashboard

Open jnvtnguyen opened this issue 1 year ago • 9 comments

Overview

  1. This PR fixes or fixes part of #19745.
  2. This PR does the following: This PR migrates the topics and skills dashboard and creator dashboard from AngularJS to Angular.

Essential Checklist

  • [x] The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
  • [x] I have followed the instructions for making a code change.
  • [ ] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
  • [x] The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
  • [x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)

Proof that changes are correct

Topics and Skills Dashboard https://github.com/oppia/oppia/assets/70992422/674406fe-458f-4103-b043-54373f6d2265

Creator Dashboard https://github.com/oppia/oppia/assets/70992422/81e238a6-394e-45fd-bab2-3e0b9f2e0141

PR Pointers

  • Never force push! If you do, your PR will be closed.
  • To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
  • Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
  • See the Code Owner's wiki page for what code owners will expect.

jnvtnguyen avatar Feb 14 '24 02:02 jnvtnguyen

Hi @jnvtnguyen, can you complete the following:

  1. The body of this PR is missing the required description, please update the body with a description of what this PR does.
  2. The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing. Thanks!

oppiabot[bot] avatar Feb 14 '24 02:02 oppiabot[bot]

Hi @jnvtnguyen please assign the required reviewer(s) for this PR. Thanks!

oppiabot[bot] avatar Feb 14 '24 02:02 oppiabot[bot]

@DubeySandeep BTW, I was looking at my old PR migrating the moderator pages and saw a few typos so I fixed it here.

jnvtnguyen avatar Feb 14 '24 02:02 jnvtnguyen

BTW, I was looking at my old PR migrating the moderator pages and saw a few typos so I fixed it here.

No problem and thanks for fixing it! :) Also, assign me to this PR once it's ready for review or if you have any questions! :)

DubeySandeep avatar Feb 14 '24 08:02 DubeySandeep

Hi @jnvtnguyen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

oppiabot[bot] avatar Feb 14 '24 10:02 oppiabot[bot]

@DubeySandeep Can you look at it briefly, still need to fix e2e errors.

jnvtnguyen avatar Feb 15 '24 22:02 jnvtnguyen

Unassigning @DubeySandeep since the review is done.

oppiabot[bot] avatar Feb 16 '24 19:02 oppiabot[bot]

@jnvtnguyen Quick check on PR status, how is it going and do you see any blockers?

DubeySandeep avatar Feb 19 '24 18:02 DubeySandeep

@DubeySandeep Will work on this later this week have exams right now.

jnvtnguyen avatar Feb 19 '24 18:02 jnvtnguyen

Hi @jnvtnguyen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

oppiabot[bot] avatar Feb 21 '24 21:02 oppiabot[bot]

@DubeySandeep Going to close and reflect the changes on a new branch.

jnvtnguyen avatar Feb 25 '24 17:02 jnvtnguyen