oppia
oppia copied to clipboard
Fix part of #19435: Migrate topics and skills dashboard and creator dashboard
Overview
- This PR fixes or fixes part of #19745.
- This PR does the following: This PR migrates the topics and skills dashboard and creator dashboard from AngularJS to Angular.
Essential Checklist
- [x] The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
- [x] I have followed the instructions for making a code change.
- [ ] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
- [x] The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
- [x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
Proof that changes are correct
Topics and Skills Dashboard https://github.com/oppia/oppia/assets/70992422/674406fe-458f-4103-b043-54373f6d2265
Creator Dashboard https://github.com/oppia/oppia/assets/70992422/81e238a6-394e-45fd-bab2-3e0b9f2e0141
PR Pointers
- Never force push! If you do, your PR will be closed.
- To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
- Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
- See the Code Owner's wiki page for what code owners will expect.
Hi @jnvtnguyen, can you complete the following:
- The body of this PR is missing the required description, please update the body with a description of what this PR does.
- The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing. Thanks!
Hi @jnvtnguyen please assign the required reviewer(s) for this PR. Thanks!
@DubeySandeep BTW, I was looking at my old PR migrating the moderator pages and saw a few typos so I fixed it here.
BTW, I was looking at my old PR migrating the moderator pages and saw a few typos so I fixed it here.
No problem and thanks for fixing it! :) Also, assign me to this PR once it's ready for review or if you have any questions! :)
Hi @jnvtnguyen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!
@DubeySandeep Can you look at it briefly, still need to fix e2e errors.
Unassigning @DubeySandeep since the review is done.
@jnvtnguyen Quick check on PR status, how is it going and do you see any blockers?
@DubeySandeep Will work on this later this week have exams right now.
Hi @jnvtnguyen. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!
@DubeySandeep Going to close and reflect the changes on a new branch.