oppia
oppia copied to clipboard
oppia
Fix part of issue #19435: Migrate contributor dashboard Admin Page
Overview
- This PR fixes or fixes part of #19435.
- This PR does the following: Migrates the contributor dashboard admin page from Webpack/AngularJS to Lazy-Loaded Angular Modules.
Essential Checklist
- [x] The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
- [x] I have followed the instructions for making a code change.
- [x] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I don't have permissions to assign reviewers directly).
- [x] The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
- [x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
Proof that changes are correct
migrate_contributor_dashboard_admin_page.webm
PR Pointers
- Never force push! If you do, your PR will be closed.
- To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
- Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
- See the Code Owner's wiki page for what code owners will expect.
![oppiabot[bot] avatar](https://avatars.githubusercontent.com/in/11091?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @shivanandan17, it looks like some changes were requested on this pull request by @DubeySandeep. PTAL. Thanks!
Unassigning @shivanandan17 since a re-review was requested. @shivanandan17, please make sure you have addressed all review comments. Thanks!
Hi @shivanandan17. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!
Unassigning @shivanandan17 since a re-review was requested. @shivanandan17, please make sure you have addressed all review comments. Thanks!
@shivanandan17 Make sure to reply to all the open threads: https://github.com/oppia/oppia/pull/19703#discussion_r1490122870
@chris7716 Can you please review this PR? (waiting on review for the last 4 days)
My review is not needed since @DubeySandeep already reviewed on behalf of dev workflow, so I'm deassigning myself. If you still want me to take a look, please feel free to re-assign me with an explanation of how I can help
@shivanandan17 How is this PR going? Any rough estimate on when we can get this merged?
I am still debugging and trying to figure out where I went wrong sir. I apologise for the delay sir.
Unassigning @shivanandan17 since a re-review was requested. @shivanandan17, please make sure you have addressed all review comments. Thanks!
Unassigning myself cuz the author needs to address my comment.
PTAL @chris7716
Hi @shivanandan17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!
@shivanandan17 Congrats on your first PR to Oppia! :tada: I'm going to restart the flaky tests and get your PR merged! :)
@shivanandan17 Congrats on your first PR to Oppia! :tada: I'm going to restart the flaky tests and get your PR merged! :)
Thank you sir