oppia icon indicating copy to clipboard operation
oppia copied to clipboard

Published 20 hours ago • verified publisher icon oppia

Fix part of #13055: handle translation cards that only consist of digits.

Open qinghaoyang opened this issue 2 years ago • 4 comments

Overview

  1. This PR fixes part of #13055.
  2. This PR does the following: Ignore cards that only consist of digits. Add a job test to ensure that runningGenerateExplorationOpportunitySummariesJob does not count the contents that only consist of digits.

Essential Checklist

  • [ ] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • [ ] The linter/Karma presubmit checks have passed locally on your machine.
  • [ ] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • [ ] The PR is made from a branch that's not called "develop".

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Proof of changes on mobile phone

Proof of changes in Arabic language

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

qinghaoyang avatar Sep 16 '22 21:09 qinghaoyang

Hi @qinghaoyang, can you complete the following:

  1. The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing. Thanks!

oppiabot[bot] avatar Sep 16 '22 21:09 oppiabot[bot]

Hi, @qinghaoyang, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @qinghaoyang to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

oppiabot[bot] avatar Sep 16 '22 21:09 oppiabot[bot]

Hi @qinghaoyang, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

oppiabot[bot] avatar Sep 19 '22 10:09 oppiabot[bot]

Hi @qinghaoyang, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

oppiabot[bot] avatar Sep 21 '22 16:09 oppiabot[bot]

@jahd2602 Could you take a look at this draft PR?

qinghaoyang avatar Sep 25 '22 20:09 qinghaoyang

@sagangwee this is a backend PR, do you know who can review backend PRs?

jahd2602 avatar Sep 26 '22 18:09 jahd2602

@qinghaoyang Is there a reason this is still in draft status?

seanlip avatar Sep 27 '22 17:09 seanlip

Um, no reason. I will submit a new PR.

qinghaoyang avatar Sep 27 '22 18:09 qinghaoyang

Oh, I think you can just mark this one as "ready for review". No need to submit a new one.

seanlip avatar Sep 27 '22 18:09 seanlip

Hi @qinghaoyang, can you complete the following:

  1. The karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing. Thanks!

oppiabot[bot] avatar Sep 27 '22 18:09 oppiabot[bot]

Hi, @qinghaoyang, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR pointers. Assigning @qinghaoyang to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

oppiabot[bot] avatar Sep 27 '22 18:09 oppiabot[bot]

@seanlip Oh, thank you.

qinghaoyang avatar Sep 27 '22 18:09 qinghaoyang

Hi @qinghaoyang, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

oppiabot[bot] avatar Sep 30 '22 07:09 oppiabot[bot]

@seanlip I checked that the migration works safely. The videos and explanations were added into the decription of this PR. PTAL

qinghaoyang avatar Oct 03 '22 15:10 qinghaoyang

Unassigning @qinghaoyang since a re-review was requested. @qinghaoyang, please make sure you have addressed all review comments. Thanks!

oppiabot[bot] avatar Oct 03 '22 15:10 oppiabot[bot]

Hi @qinghaoyang, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

oppiabot[bot] avatar Oct 04 '22 09:10 oppiabot[bot]

Hi @qinghaoyang, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

oppiabot[bot] avatar Oct 04 '22 16:10 oppiabot[bot]

Hi @sagangwee, this PR is ready to be merged. Author of this PR does not have permissions to merge this PR. Before you merge it, please make sure that there are no pending comments that require action from the author's end. Thanks!

oppiabot[bot] avatar Oct 05 '22 21:10 oppiabot[bot]

Hi @qinghaoyang, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

oppiabot[bot] avatar Oct 07 '22 11:10 oppiabot[bot]

Hi @qinghaoyang, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

oppiabot[bot] avatar Oct 10 '22 09:10 oppiabot[bot]