Fix part of #5734: Enhance the LintProjectDescription utility to generate XML files
Explanation
Fixes part of #5734
Project [PR 1.5 of project 4.3]
This PR includes the following updates:
- Implement in BazelClient to execute Bazel queries for file path collection
bazel cquery "deps($bazelTarget)" --output=filesbazel info
- Set project level tags and attributes in XML
- Set module level tags and attributes in XML
Essential Checklist
- [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
- [x] Any changes to scripts/assets files have their rationale included in the PR explanation.
- [x] The PR follows the style guide.
- [x] The PR does not contain any unnecessary code changes from Android Studio (reference).
- [x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
- [x] The PR is assigned to the appropriate reviewers (reference).
Coverage Report
Results
Number of files assessed: 4 Overall Coverage: 83.31% Coverage Analysis: FAIL :x:
Failing coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
68.29% | 84 / 123 | :x: | 70% |
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
BazelClient.ktscripts/src/java/org/oppia/android/scripts/common/BazelClient.kt |
98.25% | 112 / 114 | :white_check_mark: | 70% |
TestBazelWorkspace.ktscripts/src/java/org/oppia/android/scripts/testing/TestBazelWorkspace.kt |
98.94% | 186 / 188 | :white_check_mark: | 70% |
LintProjectDescription.ktscripts/src/java/org/oppia/android/scripts/lint/LintProjectDescription.kt |
72.48% | 187 / 258 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 4 Overall Coverage: 85.19% Coverage Analysis: PASS :white_check_mark:
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
BazelClient.ktscripts/src/java/org/oppia/android/scripts/common/BazelClient.kt |
98.25% | 112 / 114 | :white_check_mark: | 70% |
TestBazelWorkspace.ktscripts/src/java/org/oppia/android/scripts/testing/TestBazelWorkspace.kt |
98.94% | 186 / 188 | :white_check_mark: | 70% |
LintProjectDescription.ktscripts/src/java/org/oppia/android/scripts/lint/LintProjectDescription.kt |
72.00% | 180 / 250 | :white_check_mark: | 70% |
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
78.86% | 97 / 123 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 4 Overall Coverage: 84.30% Coverage Analysis: PASS :white_check_mark:
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
BazelClient.ktscripts/src/java/org/oppia/android/scripts/common/BazelClient.kt |
98.25% | 112 / 114 | :white_check_mark: | 70% |
TestBazelWorkspace.ktscripts/src/java/org/oppia/android/scripts/testing/TestBazelWorkspace.kt |
98.94% | 186 / 188 | :white_check_mark: | 70% |
LintProjectDescription.ktscripts/src/java/org/oppia/android/scripts/lint/LintProjectDescription.kt |
70.34% | 185 / 263 | :white_check_mark: | 70% |
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
78.86% | 97 / 123 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 4 Overall Coverage: 78.93% Coverage Analysis: FAIL :x:
Failing coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
LintProjectDescription.ktscripts/src/java/org/oppia/android/scripts/lint/LintProjectDescription.kt |
63.13% | 238 / 377 | :x: | 70% |
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
BazelClient.ktscripts/src/java/org/oppia/android/scripts/common/BazelClient.kt |
98.25% | 112 / 114 | :white_check_mark: | 70% |
TestBazelWorkspace.ktscripts/src/java/org/oppia/android/scripts/testing/TestBazelWorkspace.kt |
98.94% | 186 / 188 | :white_check_mark: | 70% |
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
78.86% | 97 / 123 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 4 Overall Coverage: 87.03% Coverage Analysis: PASS :white_check_mark:
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
BazelClient.ktscripts/src/java/org/oppia/android/scripts/common/BazelClient.kt |
98.25% | 112 / 114 | :white_check_mark: | 70% |
TestBazelWorkspace.ktscripts/src/java/org/oppia/android/scripts/testing/TestBazelWorkspace.kt |
98.94% | 186 / 188 | :white_check_mark: | 70% |
LintProjectDescription.ktscripts/src/java/org/oppia/android/scripts/lint/LintProjectDescription.kt |
80.37% | 303 / 377 | :white_check_mark: | 70% |
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
78.86% | 97 / 123 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 9 Overall Coverage: 87.03% Coverage Analysis: PASS :white_check_mark:
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
BazelClient.ktscripts/src/java/org/oppia/android/scripts/common/BazelClient.kt |
98.25% | 112 / 114 | :white_check_mark: | 70% |
TestBazelWorkspace.ktscripts/src/java/org/oppia/android/scripts/testing/TestBazelWorkspace.kt |
98.94% | 186 / 188 | :white_check_mark: | 70% |
LintProjectDescription.ktscripts/src/java/org/oppia/android/scripts/lint/LintProjectDescription.kt |
80.37% | 303 / 377 | :white_check_mark: | 70% |
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
78.86% | 97 / 123 | :white_check_mark: | 70% |
Exempted coverage
Files exempted from coverage
| File | Exemption Reason |
|---|---|
FlashbackButtonViewModel.ktapp/src/main/java/org/oppia/android/app/player/state/itemviewmodel/FlashbackButtonViewModel.kt |
This file is exempted from having a test file; skipping coverage check. |
StateItemViewModel.ktapp/src/main/java/org/oppia/android/app/player/state/itemviewmodel/StateItemViewModel.kt |
This file is exempted from having a test file; skipping coverage check. |
StateFragment.ktapp/src/main/java/org/oppia/android/app/player/state/StateFragment.kt |
This file is incompatible with code coverage tooling; skipping coverage check. |
StateFragmentPresenter.ktapp/src/main/java/org/oppia/android/app/player/state/StateFragmentPresenter.kt |
This file is exempted from having a test file; skipping coverage check. |
StatePlayerRecyclerViewAssembler.ktapp/src/main/java/org/oppia/android/app/player/state/StatePlayerRecyclerViewAssembler.kt |
This file is exempted from having a test file; skipping coverage check. |
Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.
To learn more, visit the Oppia Android Code Coverage wiki page
Hi @adhiamboperes PTAL.
CC: @bhavukJain
Coverage Report
Results
Number of files assessed: 4 Overall Coverage: 87.06% Coverage Analysis: PASS :white_check_mark:
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
LintProjectDescription.ktscripts/src/java/org/oppia/android/scripts/lint/LintProjectDescription.kt |
80.37% | 303 / 377 | :white_check_mark: | 70% |
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
79.20% | 99 / 125 | :white_check_mark: | 70% |
TestBazelWorkspace.ktscripts/src/java/org/oppia/android/scripts/testing/TestBazelWorkspace.kt |
98.94% | 186 / 188 | :white_check_mark: | 70% |
BazelClient.ktscripts/src/java/org/oppia/android/scripts/common/BazelClient.kt |
98.25% | 112 / 114 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
@adhiamboperes PTAL all comments are addressed/resolved.
Cc: @bhavukJain
@adhiamboperes apologies for that, I have fixed the issue, the checks should pass now. Thanks!
Coverage Report
Results
Number of files assessed: 5 Overall Coverage: 86.27% Coverage Analysis: PASS :white_check_mark:
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
LintProjectDescription.ktscripts/src/java/org/oppia/android/scripts/lint/LintProjectDescription.kt |
80.37% | 303 / 377 | :white_check_mark: | 70% |
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
73.88% | 99 / 134 | :white_check_mark: | 70% |
TestBazelWorkspace.ktscripts/src/java/org/oppia/android/scripts/testing/TestBazelWorkspace.kt |
98.94% | 186 / 188 | :white_check_mark: | 70% |
AndroidBuildSdkProperties.ktscripts/src/java/org/oppia/android/scripts/common/AndroidBuildSdkProperties.kt |
100.00% | 10 / 10 | :white_check_mark: | 70% |
BazelClient.ktscripts/src/java/org/oppia/android/scripts/common/BazelClient.kt |
98.25% | 112 / 114 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page