Fix part of #5734: Adding tests for Lint tool execution
Explanation
Fixes part of #5734
Project
[PR 1.4 of project 4.3]
This PR includes the following updates:
- Add tests for Lint tool execution
- Set up lint-test library
- Added --test_env flag in
.bazelrc
Essential Checklist
- [ ] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
- [ ] Any changes to scripts/assets files have their rationale included in the PR explanation.
- [ ] The PR follows the style guide.
- [ ] The PR does not contain any unnecessary code changes from Android Studio (reference).
- [ ] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
- [ ] The PR is assigned to the appropriate reviewers (reference).
Coverage Report
Results
Number of files assessed: 2 Overall Coverage: 90.95% Coverage Analysis: FAIL :x:
Failing coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
56.52% | 26 / 46 | :x: | 70% |
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
LintAnalysisReporter.ktscripts/src/java/org/oppia/android/scripts/lint/LintAnalysisReporter.kt |
98.98% | 195 / 197 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 2 Overall Coverage: 92.18% Coverage Analysis: FAIL :x:
Failing coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
63.04% | 29 / 46 | :x: | 70% |
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
LintAnalysisReporter.ktscripts/src/java/org/oppia/android/scripts/lint/LintAnalysisReporter.kt |
98.98% | 195 / 197 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 2 Overall Coverage: 93.00% Coverage Analysis: FAIL :x:
Failing coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
67.39% | 31 / 46 | :x: | 70% |
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
LintAnalysisReporter.ktscripts/src/java/org/oppia/android/scripts/lint/LintAnalysisReporter.kt |
98.98% | 195 / 197 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 2 Overall Coverage: 93.42% Coverage Analysis: FAIL :x:
Failing coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
69.57% | 32 / 46 | :x: | 70% |
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
LintAnalysisReporter.ktscripts/src/java/org/oppia/android/scripts/lint/LintAnalysisReporter.kt |
98.98% | 195 / 197 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 2 Overall Coverage: 97.98% Coverage Analysis: PASS :white_check_mark:
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
LintAnalysisReporter.ktscripts/src/java/org/oppia/android/scripts/lint/LintAnalysisReporter.kt |
99.01% | 200 / 202 | :white_check_mark: | 70% |
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
93.48% | 43 / 46 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Coverage Report
Results
Number of files assessed: 2 Overall Coverage: 97.63% Coverage Analysis: PASS :white_check_mark:
Passing coverage
Files with passing code coverage
| File | Coverage | Lines Hit | Status | Min Required |
|---|---|---|---|---|
LintAnalysisReporter.ktscripts/src/java/org/oppia/android/scripts/lint/LintAnalysisReporter.kt |
98.54% | 203 / 206 | :white_check_mark: | 70% |
AndroidLintRunner.ktscripts/src/java/org/oppia/android/scripts/lint/AndroidLintRunner.kt |
93.62% | 44 / 47 | :white_check_mark: | 70% |
To learn more, visit the Oppia Android Code Coverage wiki page
Hi @adhiamboperes, PTAL. All comments have been addressed.
Cc: @bhavukJain
@manas-yu, please resolve the conflicts and reassign.
@adhiamboperes Fixed. PTAL
Hi @adhiamboperes PTAL. Thanks!
Followed up to the comment thread I was at-mentioned on.
Hi @adhiamboperes PTAL.
Unassigning @adhiamboperes since they have already approved the PR.
Assigning @BenHenning for code owner reviews. Thanks!
@adhiamboperes all comments are resolved PTAL.
Updating from develop and enabling automerge.