oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

[Feature Request]: Add Missing style Attributes to TextViews

Open manas-yu opened this issue 11 months ago • 7 comments

Is your feature request related to a problem? Please describe.

The TextViewStyleCheck script was introduced in #5599 to ensure all TextView elements in layout XML files use centrally managed styles to support consistent design and proper RTL/LTR settings. However, a list of hardcoded exceptions (attributeIds) has been added to bypass the style check for specific TextView elements that currently lack a style attribute.

This issue aims to address these exceptions by updating the respective TextView elements to include appropriate centrally managed style attributes.

Describe the solution you'd like

  1. Identify the missing styles for each TextView ID in the attributeIds list and determine the appropriate style that should be applied.
  2. If an existing style is available, reuse it. Otherwise, define a new style in the styles.xml file.
  3. Update every corresponding TextView element to use the identified or newly created style, and then remove its ID from the attributeIds list in the TextViewStyleCheck script.

Describe alternatives you've considered

No response

Additional context

No response

manas-yu avatar Jan 22 '25 12:01 manas-yu

@adhiamboperes please assign me this issue.

Harsh2118-hub avatar Jan 23 '25 13:01 Harsh2118-hub

@Harsh2118-hub, I am assigning this issue to you.

Please note that, the linked list of ids is for 100 textviews, so the expectation is to create a PR with not more than 10 ids at a time. This is because you need to upload before and after screenshots for each screen that you have added a style for, so that we can verify that it looks the same as it is currently.

adhiamboperes avatar Jan 23 '25 13:01 adhiamboperes

I am encountering an issue where I cannot find the file TextViewStyleCheck.kt in my Android Studio project. Any help on how to locate this file or resolve this issue would be greatly appreciated.

Thank you!

Harsh2118-hub avatar Jan 25 '25 11:01 Harsh2118-hub

Hi @Harsh2118-hub, the changes in #5599 are yet to be merged but should be merged soon. In the meantime, you can reference the TextView IDs here.

manas-yu avatar Jan 25 '25 13:01 manas-yu

@Harsh2118-hub, the TextViewStyleCheck script is now available. Please update your branch and pull the latest changes to access it.

manas-yu avatar Jan 28 '25 10:01 manas-yu

Hii , I would like to contribute on this . Please assign it to me sir/mam. Thanks!!

devabhishekagrahari avatar Mar 30 '25 10:03 devabhishekagrahari

Hi @devabhishekagrahari, this issue is assigned to @Harsh2118-hub. Could you please take a look at this list that is available for uptake?

adhiamboperes avatar Mar 31 '25 10:03 adhiamboperes