oppia
[BUG]: Disable Spotlights in Production
Describe the bug
In the recently release beta 0.13, spotlights are enabled, when they should not be.
Steps To Reproduce
- Install the beta app via Playstore.
- Login to profile
- Spotlights will be shown
- Select a topic to play
- More spotlights are shown
Expected Behavior
Spotlights should not be shown as it is an alpha-only feature.
Screenshots/Videos
https://github-production-user-asset-6210df.s3.amazonaws.com/12983742/243485773-e499f4b6-4609-4e58-871f-a09ebd09a80d.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20241014%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20241014T104240Z&X-Amz-Expires=300&X-Amz-Signature=40094c61d3f23a690601e3d9f6ca42ec46bebf1d9a243c0f8763364e6242bbe5&X-Amz-SignedHeaders=host
What device/emulator are you using?
No response
Which Android version is your device/emulator running?
No response
Which version of the Oppia Android app are you using?
0.13-beta
Additional Context
No response
@Vinay-Khanagavi PTAL https://github-production-user-asset-6210df.s3.amazonaws.com/12983742/243485773-e499f4b6-4609-4e58-871f-a09ebd09a80d.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20241014%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20241014T104240Z&X-Amz-Expires=300&X-Amz-Signature=40094c61d3f23a690601e3d9f6ca42ec46bebf1d9a243c0f8763364e6242bbe5&X-Amz-SignedHeaders=host
@adhiamboperes! It seems like a flag might have slipped through during the beta release process.
I'll take a look at the code and make sure spotlights are only enabled for alpha builds going forward. 👍
Confirming that I apparently enabled this in FeatureFlagConstants per my local release-0.13 directory. Going to send a change to fix this 'properly' by gating it on alpha only builds.
Thanks for reporting @adhiamboperes.
Also: note that this will be automatically fixed on the next release of the app since we won't have it enabled for beta builds (and I'll double check that they are off for beta).
This should be fixed in the latest version of the app. Thanks again for filing this @adhiamboperes!