oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Fix #5393: Make hasProtoExtra centralized.

Open Vishwajith-Shettigar opened this issue 8 months ago • 5 comments

Explanation

Fixes #5393 Created ProtoExtraMatcher class to make hasProtoExtra matcher centralized.

Essential Checklist

  • [ ] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • [ ] Any changes to scripts/assets files have their rationale included in the PR explanation.
  • [ ] The PR follows the style guide.
  • [ ] The PR does not contain any unnecessary code changes from Android Studio (reference).
  • [ ] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • [ ] The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Vishwajith-Shettigar avatar Jun 27 '24 04:06 Vishwajith-Shettigar