oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Fixes #4614: Changed the background color according to accessibility scanner.

Open suyashshenoi opened this issue 1 year ago • 4 comments

Fixed: Topic Images to match A11YS

Explanation

Essential Checklist

  • [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • [x] Any changes to scripts/assets files have their rationale included in the PR explanation.
  • [x] The PR follows the style guide.
  • [x] The PR does not contain any unnecessary code changes from Android Studio (reference).
  • [x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • [x] The PR is assigned to the appropriate reviewers (reference).

WhatsApp Image 2024-04-29 at 01 53 15_47490bfd

WhatsApp Image 2024-05-01 at 00 30 21_96db2eb5

The topic and recently played images no longer have an issue with the Accessibility Checker.

This is a fix. Resolves https://github.com/oppia/oppia-android/issues/4614

suyashshenoi avatar Apr 29 '24 13:04 suyashshenoi

Thanks @suyashshenoi! Could you please also add the updated screenshots for the "Recently Played Stories"?

adhiamboperes avatar Apr 30 '24 09:04 adhiamboperes

@adhiamboperes I have added the updated screenshots for the "Recently Played Stories" too. Pls check it and let me know if anything else is remaining. Thank you.

suyashshenoi avatar Apr 30 '24 19:04 suyashshenoi

@BenHenning @adhiamboperes PTAL.

suyashshenoi avatar May 02 '24 12:05 suyashshenoi

Unassigning @suyashshenoi since a re-review was requested. @suyashshenoi, please make sure you have addressed all review comments. Thanks!

oppiabot[bot] avatar May 02 '24 13:05 oppiabot[bot]

Unassigning @BenHenning since they have already approved the PR.

oppiabot[bot] avatar May 07 '24 21:05 oppiabot[bot]

Hi @suyashshenoi, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

oppiabot[bot] avatar May 07 '24 21:05 oppiabot[bot]