oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Tests for Continue button navigation button animation are failing

Open JishnuGoyal opened this issue 3 years ago • 4 comments

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Demonstration If applicable, add screenshots or videos to help explain your problem.

Environment

  • Device/emulator being used: <device version/emulator>
  • Android or SDK version (e.g. Android 5 or SDK 21): <os/sdk version>
  • App version (you can get this through system app settings or via the admin controls menu in-app):

Additional context Add any other context about the problem here.

JishnuGoyal avatar Nov 17 '22 20:11 JishnuGoyal

i would love you work on this issue !! please assign me this

AffanShaikhsurab avatar Mar 07 '25 04:03 AffanShaikhsurab

@AffanShaikhsurab, please share with us your proposed solution to the issue, the I can assign it to you.

adhiamboperes avatar Mar 12 '25 14:03 adhiamboperes

Is anyone working on this issue currently? If not I would like to work on it.

shrimpnaur avatar Jun 01 '25 21:06 shrimpnaur

@shrimpnaur, please refer to the assignees section of an issue to see whether it has been assigned to someone. Please share with us your proposed solution to the issue, then I can assign it to you.

adhiamboperes avatar Jun 02 '25 21:06 adhiamboperes

Hi @adhiamboperes, Could you please clarify the current behavior of the animation on the Continue button? Specifically:

  • When is the animation usually shown?
    
  • When is it expected to not shown?
    

These two failing tests, are trying to verify that no animation is shown. But, when I run through app UI, the animation is currently being shown.

  1. testConIntAnim_openFractions_expId1_checkButtonDoesNotAnimate
  2. testContNavBtnAnim_openMathExp_playThroughSecondState_checkContBtnDoesNotAnimateAfter45Sec

subhajitxyz avatar Jun 29 '25 16:06 subhajitxyz

Describe the bug The Continue navigation button shows an animation on the 2nd and 3rd states, which is unexpected.

To Reproduce Steps to reproduce the behavior:

  • Go to the first Test Topic.
  • Play the Prototype Exploration.
  • Observe the Continue button on the first state and click it.
  • On the second state, submit the correct answer. Wait for 45 seconds and observe the Continue button animation. Click Continue.
  • On the third state, submit the correct answer. Wait for 45 seconds and observe the Continue button animation. Click Continue.

Expected Behavior The Continue button animation should only appear in the first state.

Demonstration If applicable, add screenshots or videos to help explain the issue.

https://github.com/user-attachments/assets/3dd7feef-662c-4e6a-afee-26e59f624038

Environment Device: Oppo Reno 2F

Additional Context Relevant files to investigate:

  • StateDeck
  • ExplorationProgressController's moveToNextStateImpl()
  • ContinueButtonView.kt

subhajitxyz avatar Jul 01 '25 03:07 subhajitxyz

Hi @adhiamboperes , PTAL at this finding for GFI issue breakdown and share your feedback. Then I will add it in issue description.

subhajitxyz avatar Aug 21 '25 13:08 subhajitxyz

This LGTM, @subhajitxyz

adhiamboperes avatar Aug 24 '25 21:08 adhiamboperes

Thanks, I have updated the issue description.

subhajitxyz avatar Aug 25 '25 05:08 subhajitxyz