oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

[A11Y] Improve text scaling in promoted story card

Open vrajdesai78 opened this issue 3 years ago • 2 comments

Describe the bug With current implementation of promoted story card, accessibility scanner shows suggestion to improve text scaling as the container inside which scalable text is used has a fixed width (though we might have used sp to make it scalable). We need to introduce a new design for promoted story card such that it will pass accessibility scanner also doesn't produce #4684 issue again.

image

We can introduce a new design like above screenshot where we can set full width to the cards i.e. match _parent (with appropriate margins) which will remove the issue of accessibility. We can also show the dots at bottom which represent the number + position of items.

image

For sighted users

  • The banners will be cyclic i.e. item-0,item1,item2,item0 and repeat

For talkback users

  • The cyclic nature will stop
  • The screenreader will start from item-0, item 1, item-2 and next it will go out of list.

To Reproduce Steps to reproduce the behavior:

  1. Turn on accessibility scanner
  2. Visit Home Screen

Expected behavior Accessibility scanner should not show any suggestion to improve text scaling and also we should not re-create #4684 issue again.

Screenshot of accessibility scanner showing improvement image

Environment

  • Device/emulator being used: Realme GT Master Edition
  • Android or SDK version (e.g. Android 5 or SDK 21): Android 12
  • App version (you can get this through system app settings or via the admin controls menu in-app): 1.0

vrajdesai78 avatar Nov 08 '22 19:11 vrajdesai78

Hii i would like to contribute in this issue please assign me with this one

vishisht-dubey avatar Nov 09 '22 12:11 vishisht-dubey

This is more of a feature and will require a lot of familiarity with the app in order to work on it @vishisht08. Might I suggest one of our other issues, instead? They may be more approachable in helping you get up-to-speed with the app before trying to tackle this issue.

BenHenning avatar Nov 15 '22 00:11 BenHenning

Hi @adhiamboperes, the accessibility scanner currently does not display the "improve text scaling" suggestion in the home screen, so I just wanted to confirm the issue requirements.

Image

manas-yu avatar Feb 04 '25 11:02 manas-yu

Thanks @manas-yu. I am happy to close this for now based on your findings.

adhiamboperes avatar Feb 17 '25 08:02 adhiamboperes