oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard
verified publisher icon oppia

Fixes part of #4177: Dark mode Topic Activity Part 5 (Lesson Tab)

Open MohitGupta121 opened this issue 3 years ago • 1 comments

Explanation

Fixes part of #4177: Dark mode Topic Activity Part 5 (Lesson tab)

Dark Mode Mockup:-

  • https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/4705f47b-9ada-4159-8b81-8db32cd3737d/specs/
  • https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/68a7a92f-c3ca-46f3-9519-914e016c5aa5/specs/
Default Dark Mode
Screenshot_2022-05-31-12-23-27-332_com android camera
Screenshot_2022-05-31-12-23-27-332_com android camera
Screenshot_2022-05-31-12-23-27-332_com android camera

Essential Checklist

  • [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • [x] Any changes to scripts/assets files have their rationale included in the PR explanation.
  • [x] The PR follows the style guide.
  • [x] The PR does not contain any unnecessary code changes from Android Studio (reference).
  • [x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • [x] The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

MohitGupta121 avatar Sep 23 '22 17:09 MohitGupta121

https://user-images.githubusercontent.com/76530270/192149580-815e7f1a-b15d-418e-93bc-5b889892e1d5.png

@rt4914 @BenHenning UI of Lesson lessons_chapter_view is now changed and according to my PR it's old one in which we using only lessons_chapter_view.xml Can you please share the mockups of Dark Mode for Lessons Fragment. So that I update this PR accoridng to that.

In AdobeXd I not find new mockups.

MohitGupta121 avatar Sep 25 '22 14:09 MohitGupta121

@MohitGupta121 I suggest closing this PR because the new mocks are not ready right now for Dark Mode and it might take some time.

Instead do this:

  1. File a separate Dark Mode issue for Lessons tab and clearly mention that its blocked on mocks.
  2. Close this PR
  3. Close 4177 issue as it will be considered complete too.

@BenHenning Do let me know your thoughts too.

rt4914 avatar Sep 27 '22 14:09 rt4914

@rt4914 Okay sure, I'll be closing this PR as I blocked this issue as dark mode mockups are not ready yet and also issue #4177

I am opening a new issue for the dark mode of the Lessons Tab.

MohitGupta121 avatar Sep 27 '22 14:09 MohitGupta121