Fix #4322 : Fixes Talkback reading astreisk Issue

[Ryggs]

Explanation

This PR fixesTalkback reading astreisk Issue by stopping talkback from pronouncing the word asterisks, and instead pronounces the word required.

Essential Checklist

• [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• [x] Any changes to scripts/assets files have their rationale included in the PR explanation.
• [x] The PR follows the style guide.
• [x] The PR does not contain any unnecessary code changes from Android Studio (reference).
• [x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• [x] The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Demo Video

aste.webm

Tests

[Ryggs]

@BenHenning, this duplicate causes breaks. But its present in the origin/develop. As seen here https://github.com/oppia/oppia-android/blob/develop/app/src/main/res/values/color_defs.xml

Build Error Image:

[BenHenning]

Sending this back to you @Ryggs per the comment above, and also converting it to be a draft PR since it's still a work-in-progress.

[BenHenning]

@Ryggs unless I'm mistaken, this PR should be able to be finished up and sent for full review. Am I missing anything?

[Ryggs]

Thanks @Ryggs. Took a pass on it.

Could you please also update the PR description to include before/after videos showing all affected fields to more clearly demonstrate how they work with the new flow? This should include both Talkback and non-Talkback versions (i.e. 4 videos altogether) since all versions of the screen are being changed in this PR.

Beyond that, once AddProfileActivityTest is completed you should also add screenshots to the PR description showing that it's still passing in Espresso (given that it's being changed a lot in this PR), but I suggest waiting until all new tests are added to avoid needing to re-run the Espresso tests again.

Hi @BenHenning , please help me clarify what ". 4 videos altogether) since all versions of the screen" means in this sense. Could it be phone and tablet(Talkback and non-Talkback)?

[seanlip]

@Ryggs There are two choices for before/after, and two choices for Talkback/non-Talkback. Each combination of these results in a total of 4 videos: (before + Talkback), (before + non-Talkback), (after + Talkback), (after + non-Talkback).

[Ryggs]

@Ryggs There are two choices for before/after, and two choices for Talkback/non-Talkback. Each combination of these results in a total of 4 videos: (before + Talkback), (before + non-Talkback), (after + Talkback), (after + non-Talkback).

Got it, thank you.

[BenHenning]

Assigning @rt4914 since I think he can take a look at this now.

[rt4914]

I will review it today.

[oppiabot[bot]]

Unassigning @rt4914 since they have already approved the PR.

[oppiabot[bot]]

Assigning @BenHenning for code owner reviews. Thanks!