Fix #4581: Privacy policy hyperlink in Terms of Service

[veena14cs]

Explanation

Fixes #4581 . This PR fixes the privacy policy hyperlink in Terms of service page.

Before and after video

https://user-images.githubusercontent.com/16301028/191303416-fb26934b-f0ec-4eb5-9d32-d73869886e48.mp4

https://user-images.githubusercontent.com/16301028/191303721-53f8b25f-01aa-4b23-bf1a-2de8212c07b0.mp4

Essential Checklist

• [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• [x] Any changes to scripts/assets files have their rationale included in the PR explanation.
• [x] The PR follows the style guide.
• [x] The PR does not contain any unnecessary code changes from Android Studio (reference).
• [x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• [x] The PR is assigned to the appropriate reviewers (reference).

[BenHenning]

@rt4914 I think you can take a look at the XML change, or the broader PR if you're so inclined.

[oppiabot[bot]]

Hi @veena14cs, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[BenHenning]

Hi @veena14cs I sent this on chat, but also sending it here:

I think there are two different behaviors that need to be verified here, and at different levels:

• Clicking the hyperlink calls the activity's listener callback. This is verified in the fragment test, and should be verified like we do for the beta notice fragment: https://github.com/oppia/oppia-android/blob/18814f57b00ec8d3e25536a5c6b6633138ac677c/app/src/main/java/org/oppia/android/app/notice/testing/BetaNoticeDialogFragmentTestActivity.kt#L16 (where we use a mock assigned in the test and verified there).
• Clicking the hyperlink opens the correct activity (this should be verified in an activity test since it's verifying the activity's behavior, not the fragment's).

At the moment, I think your test is conflating testing an activity behavior at the fragment level, and this is resulting in actually testing the test activity which isn't what we want

[veena14cs]

Thanks @veena14cs. Took another pass--PTAL.

Thanks. I have fixed the issue. PTAL.

[veena14cs]

Thanks @veena14cs! Just a few nits left, otherwise this LGTM.

Thanks @BenHenning I have fixed nits. PTAL.

[oppiabot[bot]]

Unassigning @BenHenning since they have already approved the PR.

[oppiabot[bot]]

Hi @veena14cs, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!