oppia
Fix #4445: Add scaling animation for Continue button
Explanation
Fixes #4445
This PR is part of the GSoC project: Interactive Onboarding Flow which fixes #4445. It does so by creating a new custom view which connects to the ContinueInteractionItemViewModel, which receives a flag to start animating from the explorationProgressController. We wait for 30 seconds when the first card of a lesson is opened by the user, and then start the animation for the continue button.
Essential Checklist
- [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
- [x] Any changes to scripts/assets files have their rationale included in the PR explanation.
- [x] The PR follows the style guide.
- [x] The PR does not contain any unnecessary code changes from Android Studio (reference).
- [x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
- [x] The PR is assigned to the appropriate reviewers (reference).
For UI-specific PRs only
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
- For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
- Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
- Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Hi @JishnuGoyal, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
![oppiabot[bot] avatar](https://avatars.githubusercontent.com/in/11091?v=4 "Published by a pub.dev verified publisher"){kind=small}
PTAL @BenHenning please take an initial pass at this. Tests not completed at the moment.
Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!
PTAL @BenHenning A lot has been changed in this PR since the last review, and I feel it would be worth if this underwent another pass, thanks!
Whats left:
- Add a test to check the buttons do not animate in a new exploration
- Address the CI checks
Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!
@JishnuGoyal PTAL at https://github.com/JishnuGoyal/oppia-android/pull/3 which I think will address the issues you were running into with getting StateFragmentLocalTest passing. I think it'll also fix a number of the other failures.
You should also sync with the latest develop to make sure your CI results are recent.
Thanks @BenHenning for the suggestive PR! This helped a lot. Unfortunately, there still are some problems while testing the continue navigation item. Although the app seems to work normally manually, the test cases still are able to hit a certain case where a deviation from the expected behavior is caught. As discussed, the continue navigation animation is a "should have" and not a "must have", so given the time constraints and the scope of this PR, I'm creating an issue for this that can be picked up and worked upon. This PR has work which brings us very close to finding a solution, and appropriate corresponding comments/todos/issues will be created.
Thanks!
Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!
@rt4914 also PTAL for codeowners.
@JishnuGoyal please also update to the latest develop before sending this back for review, as well.