oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Published 20 hours ago • verified publisher icon oppia

added dark mode support to profile activities and app version activity

Open aayushimathur6 opened this issue 1 year ago • 7 comments

Explanation

Fixes #4176

Profile List: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/ddc3dadf-10e4-45f6-aeea-eb8a330e00ff/specs/

Profile Edit: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/693301de-5907-4f6a-b183-037412478267/

Profile Rename: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/d0227921-1c24-4bb7-8667-a8fa5f4742dd/

Profile Reset: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/32c9276d-072c-4edf-abf9-435323bb475a/

App Version: https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/79e0846d-de5c-42b7-93aa-f93d4995616d/

Essential Checklist

  • [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • [x] Any changes to scripts/assets files have their rationale included in the PR explanation.
  • [x] The PR follows the style guide.
  • [x] The PR does not contain any unnecessary code changes from Android Studio (reference).
  • [x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • [x] The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
BEFORE AFTER
Screenshot_20220916_153310 Screenshot_20220916_152556
Screenshot_20220902_164755 Screenshot_20220902_165035
Screenshot_20220916_153741 Screenshot_20220916_152840
Screenshot_20220916_153924 Screenshot_20220916_152923
Screenshot_20220916_154020 Screenshot_20220916_153037

aayushimathur6 avatar Sep 02 '22 11:09 aayushimathur6

@rt4914 made a new pull request for issue no. 4176 (https://github.com/oppia/oppia-android/issues/4176), PTAL thanks

aayushimathur6 avatar Sep 02 '22 11:09 aayushimathur6

@rt4914 PTAL

aayushimathur6 avatar Sep 14 '22 15:09 aayushimathur6

@rt4914 also for the one check failing then do I need to add any regex pattern?

aayushimathur6 avatar Sep 14 '22 15:09 aayushimathur6

@rt4914 corrected the color, PTAL

aayushimathur6 avatar Sep 15 '22 15:09 aayushimathur6

Unassigning @aayushimathur6 since a re-review was requested. @aayushimathur6, please make sure you have addressed all review comments. Thanks!

oppiabot[bot] avatar Sep 15 '22 15:09 oppiabot[bot]

Screenshot 2022-09-15 at 1 05 16 AM

In this and similar deactivated-save-button the border color does not match with that of mocks. It should be dull https://xd.adobe.com/view/c05e9343-60f6-4c11-84ac-c756b75b940f-950d/screen/32c9276d-072c-4edf-abf9-435323bb475a/specs/

Also, have a look at this to understand how to use 8-characters color code correctly https://github.com/oppia/oppia-android/wiki/Working-on-UI#color-code

done

aayushimathur6 avatar Sep 15 '22 19:09 aayushimathur6

@rt4914 updated the content cell as well with the lightening boundary color of the save button according to the android working on UI wiki

aayushimathur6 avatar Sep 16 '22 10:09 aayushimathur6

@aayushimathur6 Merged with latest develop.

Also, I do think that the border of disabled button is quite bright as compared to mocks. Can you please check why is that, maybe expermient with colors a bit, like trying #3BD1C466 and #663BD1C4 and seeing the difference.

Done with merging for this @rt4914 earlier I was applying image this which is too bright i.e #3BD1C4 but after you shared the mock I applied the light version i.e #663BD1C4 but this is named here previously as bright image still, the check is failing Also, for #3BD1C466 this is not the color that I have to apply you can see the following image I am not getting the exact color

aayushimathur6 avatar Sep 26 '22 13:09 aayushimathur6

@rt4914 @BenHenning PTAL

aayushimathur6 avatar Oct 02 '22 11:10 aayushimathur6

Unassigning @aayushimathur6 since a re-review was requested. @aayushimathur6, please make sure you have addressed all review comments. Thanks!

oppiabot[bot] avatar Oct 02 '22 11:10 oppiabot[bot]

Sorry, will need to look at this tomorrow.

BenHenning avatar Oct 04 '22 07:10 BenHenning

Thanks @aayushimathur6. I didn't have too much to comment on, and I checked past comments from Rajat.

PTAL at my follow-up comment and also make sure that CI checks are passing before sending this back.

I have looked at your comment I was making a silly mistake, All checks have passed. PTAL @BenHenning

aayushimathur6 avatar Oct 07 '22 13:10 aayushimathur6

Unassigning @aayushimathur6 since a re-review was requested. @aayushimathur6, please make sure you have addressed all review comments. Thanks!

oppiabot[bot] avatar Oct 07 '22 13:10 oppiabot[bot]