Fix #4447: Hide Info tab

[JishnuGoyal]

Explanation

Fixes #4447

This PR hides the info tab in the Topic screen, as part of the Interactive Onboarding Flow project (GSoC), thus fixing #4447. It does so by introducing a new platform parameter enableExtraTopicTabsUi which hides info and practice tab as well. The practice tab's visibility was earlier controller by a flag called enablePracticeTab which used some legacy code and was removed in this PR. Thus, lessons tab is the default tab upon landing on the topic screen.

Essential Checklist

• [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• [x] Any changes to scripts/assets files have their rationale included in the PR explanation.
• [x] The PR follows the style guide.
• [x] The PR does not contain any unnecessary code changes from Android Studio (reference).
• [x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• [x] The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Before:

After:

[JishnuGoyal]

Please take an initial pass at this -- please let me know if more test cases are needed.

[JishnuGoyal]

Thanks! Added all the suggested changes; Please take another pass and perhaps review the tests as well. PTAL @BenHenning

[oppiabot[bot]]

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!

[BenHenning]

Also @JishnuGoyal please make sure to fill in the explanation section of the PR, and fix failing CI checks.

[JishnuGoyal]

PTAL @BenHenning . Would it be possible for you to review the tests added ? I'll check the CI fails after this pass.

[oppiabot[bot]]

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!

[oppiabot[bot]]

Hi @JishnuGoyal, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

[BenHenning]

@JishnuGoyal please also add screenshots of Espresso tests passing for changed test suites (such as TopicFragmentTest).

[JishnuGoyal]

@rt4914 PTAL for codeowners, thanks.

[oppiabot[bot]]

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!

[JishnuGoyal]

Espresso test results on my branch.

Espresso tests failing originally on develop (same status as the tests on my branch)

[JishnuGoyal]

Espresso test status on my branch

(the same test currently fails on develop too)

[JishnuGoyal]

Thank you so much, so happy to hear :)

[JishnuGoyal]

PTAL @BenHenning , thanks

[oppiabot[bot]]

Unassigning @JishnuGoyal since a re-review was requested. @JishnuGoyal, please make sure you have addressed all review comments. Thanks!