oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Published 20 hours ago • verified publisher icon oppia

Fix #4315 : Automatically Update Topics options doesn't do anything in Administrator Controls

Open Ryggs opened this issue 1 year ago • 6 comments

Explanation

This PR fixes the issue of Automatically Update Topics options not doing anything in Administrator Controls by introducing a new platform parameter and hide the 'download permissions'

Essential Checklist

  • [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • [x] Any changes to scripts/assets files have their rationale included in the PR explanation.
  • [x] The PR follows the style guide.
  • [x] The PR does not contain any unnecessary code changes from Android Studio (reference).
  • [x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • [x] The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

DEMO

  • Here's a demo video after the Fix

https://user-images.githubusercontent.com/31986629/179077354-a53f074d-2d3a-4e67-8829-e420cee8a863.mp4

Before After
befre 4315 Phone View

TESTS

image

Ryggs avatar Jul 14 '22 20:07 Ryggs

Hi @Ryggs, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot[bot] avatar Jul 21 '22 21:07 oppiabot[bot]

I have added Gradle tests results, should there be more?

@Ryggs part of what's missing, I think, is adding the new tests that are needed to verify this change, then to upload the Espresso test results for those changed test suites (to show that they still pass). There's also no need to demonstrate that Robolectric is passing since CI already does that.

BenHenning avatar Aug 04 '22 06:08 BenHenning

Hi @Ryggs, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot[bot] avatar Aug 11 '22 06:08 oppiabot[bot]

Hi @BenHenning I updated the tests for the platform parameters PTAL

Ryggs avatar Aug 15 '22 17:08 Ryggs

Hi @Ryggs, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot[bot] avatar Aug 23 '22 12:08 oppiabot[bot]

@BenHenning PTAL

Ryggs avatar Aug 31 '22 16:08 Ryggs