oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

For few of the questions in explorations the hints provided are numbered randomly

Open KolliAnitha opened this issue 2 years ago • 4 comments

Describe the bug For few of the questions in explorations the hints provided are numbered randomly

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Ratios'
  2. Click on 'Multiplication'
  3. Click on Continue to get to the question page 'how many petals there are on the flowers'
  4. Wait for hint

*Expected behavior Hint 1 should be displayed instead of hint 6

Actual Result: Hint 6 is seen

Screenshot_2022-04-29-18-21-47-60_943a62cb4c6fb83e010e1c2e82766a17.jpg

Environment Device name: One plus Nord2 5G Android version : Android 11 App version : 0.7-alpha-d1b2827517

KolliAnitha avatar May 05 '22 12:05 KolliAnitha

Ah, I was aware of this but I don't think we had an issue to track it--thanks @KolliAnitha.

The problem here is that we're currently use the content ID of the hint as its header which is incorrect. We should instead be numbering the headers in a localization-friendly way.

I think this is a good starter issue material, but marking it as a 'second issue' since the APIs for localization can be a bit tricky to learn.

BenHenning avatar May 06 '22 20:05 BenHenning

For searching context, this issue was found in 0.7-alpha (MR4).

BenHenning avatar Jun 10 '22 17:06 BenHenning

@BenHenning ,

  • I have downloaded the release assets as per the directions in this "Downloading production assets for testing release bugs" document.

  • Successfully build and run the app, as shown. https://user-images.githubusercontent.com/31986629/191573742-48cafb41-5987-4b19-a54b-7fb0c7d45310.mp4

  • Completed all the exercises under ratios, and have not come across any flower/petal-related questions or hints, as described in this issue.

WhatsApp Image 2022-09-21 at 20 00 06

  • Opened the whole folder in vs code. Search globally “content_id”:”hint_15”, and “content_id”:”hint_6”.
  • To show you that some hint content_id’s are not orderly numbered, some start from 6 then 7 or 14, 15. So maybe this could just be a numbering issue in the JSON files. As shown in the images below.

hint7

hint16

WhatsApp Image 2022-09-14 at 15 46 14 (2)

WhatsApp Image 2022-09-21 at 20 01 00

I cannot seem to find the hint text in the issue in the release assets folder. Perform a search in vs code and type in petal or the text in the photo, assigned with this issue, you will notice its absence.

Suggestion: This issue may just be fine the way it is, or the hint numbering in the JSON files is needed.

Ryggs avatar Sep 21 '22 17:09 Ryggs

@Ryggs this issue isn't fine the way it is because learners will encounter hint numbers that don't make sense to them. This comes from the fact that we're using the content IDs today for the hint name header, but content IDs are never meant to be shown to the user (so there's nothing to actually change in the lessons themselves). We should, instead, be displaying the hint number based on which hint it is, rather than based on its content ID.

BenHenning avatar Sep 22 '22 20:09 BenHenning