oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Remove empty answer box in "The Commutative and Associative Laws" chapter's first card

Open srushtirk opened this issue 2 years ago • 6 comments

Describe the bug An empty answer box appears on the first card when returned to the first card after visiting other cards in the chapter "The Commutative and Associative Laws"

To Reproduce Steps to reproduce the behavior:

  1. Go to Expressions & Equations
  2. Visit the first and second card
  3. Go back to the first card from the second card
  4. See error

Expected behavior The empty box should not be visible and needs to be removed from the UI. Only the forward arrow should be visible.

Demonstration image

Environment

  • Device/emulator being used: Pixel 5
  • Android or SDK version (e.g. Android 5 or SDK 21): Android 12
  • App version (you can get this through system app settings or via the admin controls menu in-app): 0.7-alpha-d1b2827517

Additional context Add any other context about the problem here.

srushtirk avatar Mar 30 '22 05:03 srushtirk

I would like to work on this issue.

prince02765 avatar Mar 31 '22 02:03 prince02765

This issue is currently being worked on @prince02765, apologies for the confusion.

BenHenning avatar Apr 12 '22 05:04 BenHenning

For searching context, this issue was found in 0.7-alpha (MR4).

BenHenning avatar Jun 10 '22 17:06 BenHenning

@KolliAnitha could you please check that this is still an issue in the latest beta? I thought this was addressed, but looking back through the code we actually have had something to make sure empty feedback is outright never shown. It's possible there's blank HTML in this particular lesson, but it'd be good to verify the issue actually still exists before we investigate in depth.

Edit: Ah, this can't be checked, I think, since we don't have expressions & equations in the latest beta. I think they will be included in the upcoming beta, though, so this may be something we can check as part of that release.

BenHenning avatar Mar 07 '23 18:03 BenHenning

I think this has to to with computing the playerFeatureSet of the StatePlayerRecyclerViewAssembler. A developer working on this should probably investigate https://github.com/oppia/oppia-android/blob/74f39685add3a6633f6a806aae5b3a2eb3668959/app/src/main/java/org/oppia/android/app/player/state/StatePlayerRecyclerViewAssembler.kt#L1077

adhiamboperes avatar Jun 15 '23 10:06 adhiamboperes

yes @BenHenning currently we dont have Expressions and Equations topic

KolliAnitha avatar Jun 15 '23 12:06 KolliAnitha