oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Ktlint check comment block

Open anandwana001 opened this issue 3 years ago • 9 comments

Describe the bug Currently, ktlint is not catching the comment block bad format.

/**
 * 
 * 
 * */

Expected behavior Ktlint should catch this bad format.

Correct format

/**
 *
 */

anandwana001 avatar Jun 30 '21 16:06 anandwana001

If this still open, Shall i work on this issue ?

dmdbilal avatar Jan 06 '24 11:01 dmdbilal

If this still open, Shall i work on this issue ?

Hi @dmdbilal, for the issues that you are interested in, please add a comment with your proposed solution and then we'll assign the issue to you. You can also submit a draft PR containing your preliminary solution. Thanks.

adhiamboperes avatar Jan 06 '24 11:01 adhiamboperes

What exactly I need to do in this issue @adhiamboperes ? Whether bad format means the empty lines in the multi-line comments ? or the 2nd asterisk in the last line of the comment ? And If possible can you tell me what's the correct format exactly.

dmdbilal avatar Jan 11 '24 13:01 dmdbilal

What exactly I need to do in this issue @adhiamboperes ? Whether bad format means the empty lines in the multi-line comments ? or the 2nd asterisk in the last line of the comment ? And If possible can you tell me what's the correct format exactly.

Hi,

Our code style is based on the Kotlin code style. PTAL at https://kotlinlang.org/docs/kotlin-doc.html. In this case, the issue is referring to the second asterisk in the last line.

adhiamboperes avatar Jan 13 '24 08:01 adhiamboperes

@aadityaguptaa, PTAL.

adhiamboperes avatar Mar 26 '24 02:03 adhiamboperes