oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Fix all the ignored test cases

Open anandwana001 opened this issue 4 years ago • 8 comments

Describe the bug Some of the test cases are ignored due to flakyness or blocked somewhere in other pr.

Expected behavior Need to fix all.

Test file Test issue/pr
AudioFragmentTest #56(Landscape)
ExplorationActivityTest 2 - fake audio library (https://github.com/oppia/oppia-android/issues/2480)
StateFragmentTest 3 - #1612, 1 - #1611
ImageRegionSelectionInteractionViewTest 3 - #1611 , 3 - test doesn't seems correct
InputInteractionViewTestActivityTest 4 - #56(Landscape)
NavigationDrawerActivityTest 1 - #1806(MyDownloads)[BLOCKED]
CoroutineExecutorServiceTest 2 - #1763
Test file @RunOn(TestPlatform.ESPRESSO)
NavigationDrawerActivityTest 2 - Error 'is drawer closed' doesn't match the selected view. for robolectric
TopicInfoFragmentTest 7 - #2057 Text lines/Orientation change for robolectric
QuestionPlayerActivityTest. 4 - #2057
AudioFragmentTest 1 - https://github.com/oppia/oppia-android/issues/2568
Test file Need Tests to write
QuestionPlayerActivityTest https://github.com/oppia/oppia-android/issues/503
ExplorationActivityTest TODO(#163): Fill in remaining tests for this activity. (is this completed)
StateFragmentTest TODO(#388): Add more test-cases (@khushal1707 ) ,TODO(#56): Add support for testing that previous/next button states are properly retained on config changes.

anandwana001 avatar Jan 06 '21 18:01 anandwana001

@ShridharGoel Do you want to work on ExplorationActivityTest explorationActivityTestRule.activity.isFinishing part

anandwana001 avatar Jan 07 '21 04:01 anandwana001

@anandwana001 Yes, sure.

ShridharGoel avatar Jan 07 '21 04:01 ShridharGoel

@anandwana001 may I file a new issue regarding the failing robolectric test in #2499

MaskedCarrot avatar Jan 27 '21 12:01 MaskedCarrot

Sure and please also mention here in the comment with the new issue link.

anandwana001 avatar Jan 27 '21 14:01 anandwana001

Failing roboletric tests needs to be fixed in AudioFragmentTest #2568

MaskedCarrot avatar Jan 27 '21 16:01 MaskedCarrot

@anandwana001 Is TODO(#388): Add more test-cases available now ? Can I work on this?

khushal1707 avatar Feb 16 '21 09:02 khushal1707

@khushal1707 done

anandwana001 avatar Feb 16 '21 09:02 anandwana001

I'm having exams this week and I'll try to make pull request by the end of the week for TODO:(#388)

khushal1707 avatar Feb 23 '21 02:02 khushal1707