oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Published 20 hours ago • verified publisher icon oppia

Optimise code in profile_chooser_add_view.xml

Open MohamedMedhat1998 opened this issue 4 years ago • 7 comments

This issue is tracking the optimization work of profile_chooser_add_view.xml

  1. Make sure that the layout uses ConstraintLayout and there is minimal nesting of views. If this view already uses ConstraintLayout then it's fine.

  2. Make sure that all TextViews use the style from styles.xml file like Heading1, TextFieldLabel, Body, etc. whichever suits best.

While making the above changes the UI should not get affected and the end result should still be the same as before (or an optimized version of UI).

If there are multiple files with the same name, update them all.

References

Mobile Portrait: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/grid/ Mobile Landscape: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/grid/ Tablet: https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/grid/ Wiki: https://github.com/oppia/oppia-android/wiki/Working-on-UI

MohamedMedhat1998 avatar Oct 08 '20 14:10 MohamedMedhat1998

I will work on this .

Arjupta avatar Oct 11 '20 04:10 Arjupta

I will work on this .

@ARJUPTA Before we assign you this one, can you finalize #1042 first, please?
If you are facing difficulties with #1042 we can remove your assignment there and assign you this one.
What would you prefer?

MohamedMedhat1998 avatar Oct 11 '20 11:10 MohamedMedhat1998

I am working on the #1042, but as @rt4914 suggested to look upon the rest Slop issues as that issue will take time , so I started working on this too. I will take the #1042 if have to choose between one.

Arjupta avatar Oct 11 '20 12:10 Arjupta

Ok no issues, you can work on both. I'll assign this one to you too.

MohamedMedhat1998 avatar Oct 11 '20 13:10 MohamedMedhat1998

May I work on this?

arinarora18 avatar Aug 18 '21 10:08 arinarora18

May I work on this?

@rt4914 @Sarthak2601 @aggarwalpulkit596

MohamedMedhat1998 avatar Aug 21 '21 08:08 MohamedMedhat1998

@arinarora18 Suggest working on #3556 first and then work on this issue.

rt4914 avatar Aug 23 '21 18:08 rt4914

Hi @MohitGupta121, I'd like to work on this issue. Thank you 🙏

Uticodes avatar Dec 06 '22 08:12 Uticodes

@Uticodes assigned go ahead. If you have any query feel free to ask me.

MohitGupta121 avatar Dec 06 '22 08:12 MohitGupta121

Alright, thank you. I'll review the screens, then go through the instructions again, if I have any questions, I'll let you know.

On Tue, Dec 6, 2022 at 9:47 AM MOHIT GUPTA @.***> wrote:

@Uticodes https://github.com/Uticodes assigned go ahead. If you have any query feel free to ask me.

— Reply to this email directly, view it on GitHub https://github.com/oppia/oppia-android/issues/1956#issuecomment-1338977423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKMHQHA3ABVXTCNZRXBDY7LWL34R7ANCNFSM4SI32K5A . You are receiving this because you were mentioned.Message ID: @.***>

Uticodes avatar Dec 06 '22 08:12 Uticodes