oppia-android icon indicating copy to clipboard operation
oppia-android copied to clipboard

Published 20 hours ago • verified publisher icon oppia

Story Text Size in other learner screens.

Open rt4914 opened this issue 4 years ago • 12 comments

Currently the story text size change in settings is getting reflected in exploration / StateFragment only. But I think it should get reflected in Concept Card as well as Hints & Solution because from user perspective they are also part of exploration only.

Checklist

  • [x] Implement in Hints & Solution
  • [x] Implement in Concept Card
  • [ ] Implement in Question Player
  • [x] Revision Card
  • [ ] Check that it is working on Hints & Solution of Question Player

rt4914 avatar Jul 21 '20 06:07 rt4914

Commenting for reference We can take this issue once we resolve the current bug coming in text size setting from exploration screen. https://github.com/oppia/oppia-android/issues/1540

anandwana001 avatar Jul 29 '20 03:07 anandwana001

@rt4914 Based on Ben's comment - https://github.com/oppia/oppia-android/issues/1540#issuecomment-665774109 I think we should shift this issue to beta milestone.

anandwana001 avatar Aug 04 '20 08:08 anandwana001

Hi @rt4914 @anandwana001 , I would like to work on Concept Card screen in this issue.

alokbharti avatar Nov 19 '20 06:11 alokbharti

Hi @rt4914 @anandwana001 , I would like to work on Concept Card screen in this issue.

@alokbharti Assigned in description.

rt4914 avatar Nov 20 '20 04:11 rt4914

@alokbharti any update on this?

anandwana001 avatar Jan 05 '21 04:01 anandwana001

Assigned to @FareesHussain as it is blocked on his PR. #2274

rt4914 avatar Jan 05 '21 09:01 rt4914

As per my findings, text size settings is working fine for HintsAndSolutionDialogFragment inside an exploration. But this needs to be implemented for hints and solutions of question player.

https://github.com/oppia/oppia-android/assets/84731134/b6fe3bec-9133-4743-ac82-72c18b054106

theMr17 avatar Feb 27 '24 13:02 theMr17

Hi @adhiamboperes, the existing implementation successfully updates the concept card text size along with changes in the reading text size, and I have included the recording for your reference. Is there anything specific that I may have overlooked or that still needs updating regarding the concept cards?

Asset:

https://github.com/oppia/oppia-android/assets/122200035/5684a244-df04-4edc-a29e-e5b92ecbd5a3

Rd4dev avatar Feb 27 '24 18:02 Rd4dev

Thanks for testing this @theMr17 and @Rd4dev!

The only part of this left is to verify the text size in question player, but this isn't in use at the moment.

adhiamboperes avatar Feb 29 '24 07:02 adhiamboperes

The only part of this left is to verify the text size in question player, but this isn't in use at the moment.

I had tested that part as well by changing feature flag values. The text size in question player is not in sync with the settings.

theMr17 avatar Feb 29 '24 07:02 theMr17

Thanks @theMr17!

adhiamboperes avatar Mar 01 '24 09:03 adhiamboperes

This issue similar to https://github.com/oppia/oppia-android/issues/4362, Updating PR to fix this issue.

Vishwajith-Shettigar avatar Apr 26 '24 06:04 Vishwajith-Shettigar