opnsense
security/acme-client: Add support for zyxel_gs1900 deploy script
Important notices Before you add a new report, we ask you kindly to acknowledge the following:
- [x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
- [x] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
- [x] When the request is meant for an existing plugin, I've added its name to the title.
Is your feature request related to a problem? Please describe. I've contributed a deployment script to the acme.sh project which I'd love to use on my opnsense devices.
Describe the solution you'd like I would like to attempt a PR adding support for this deployment to the existing os-acme-client plugin for opnsense.
Additional context This would be my first contribution of this type so it would likely need careful review. I already have a plugin mocked up locally which I've manually installed in opnsense and have been using for the last half a year or so while awaiting the acme.sh 3.1.2 release. This means I'll likely have a PR ready in relatively short order.
One open question is how I can ensure that this new plugin support doesn't break on opnsense installs which don't yet have the latest acme.sh 3.1.2 or later. Or how I can make sure it requires that version.
As promised I've ported my prior local modification to what I think a plugin might look like. Thank you in advance for your time and consideration.