plugins icon indicating copy to clipboard operation
plugins copied to clipboard

dns/bind: Make builtin ACLs available

Open benyamin-codez opened this issue 4 months ago • 3 comments

Makes the builtin ACLs (none, any. localhost and localnets) available for selection:

  1. Created new custom field types:
    • AclField extending ArrayField
    • AclModelRelationField extending ModelRelationField
    • AclNetField extending NetworkField
  2. Adds builtin ACLs as child nodes to ACL list via new AclField field type
  3. Removes builtin name RegEx constraint from name field in Acl model
  4. Ensures "any" and "none" builtins cannot be part of an ACL multi-select via new AclModelRelationField field type
  5. Ensures network validation is skipped for builtin ACLs via new AclNetField field type
  6. Updates the General and Domain models to use AclModelRelationField
  7. Updates general.volt to:
    • Disable command buttons for builtin ACLs
    • Ensure the builtin ACLs are added to config.xml
  8. Updates named.conf to exclude builtin ACLs from custom name list
  9. Bumps model versions:
    • Acl to v1.0.1
    • General to v1.0.13
    • Domain to v1.1.3

benyamin-codez avatar Sep 07 '25 06:09 benyamin-codez

@fichtner @mimugmail

Franco & Michael,

Let me know what you think.

If you're happy with this and the others (PRs #4894, #4897 & #4901) I'll work on a tidy up and migration scripting per PR #4892...

With kind regards, Ben

benyamin-codez avatar Sep 07 '25 06:09 benyamin-codez

Pushed two fixes:

  1. Needed the add() function from the ArrayField base field type replicated in new AclField field type
  2. Modified AclController.php so that builtin ACLs cannot be deleted by selection

This should be good to go...

benyamin-codez avatar Sep 20 '25 12:09 benyamin-codez

Here's a screen shot of the proposed ACLs tab for your consideration:

bind_acl_screen

CC: @fichtner @mimugmail

benyamin-codez avatar Sep 21 '25 23:09 benyamin-codez