net/frr: Activate peergroup in address family
Fixes: https://github.com/opnsense/plugins/issues/4762
I asked OP to test, so lets wait first, but when looking at the frr documentation its indeed at the wrong spot.
The examples do show neighbor .. activate inside the address-family block indeed, but as the name is actually an address, it should likely match the proper family. Haven't tried this on my end, but at a first glance it feels like we're missing something here.
Right now its determined automatically by which networks exist in the bgp listen range.
But it's just an assumption. E.g., if you want the peer group only for IPv4 even though you have some IPv6 networks in the listen range, it should only activate for IPv4.
Maybe a dropdown inside the Peer Group for "IPv4", "IPv6", "IPv4 and IPv6" could make it better, as it lets the user decide?
In other news the user tested it and it solves it so we are on the right track.
@Monviech can you document this in net/frr/pkg-descr?
@fichtner Done