plugins icon indicating copy to clipboard operation
plugins copied to clipboard

net/frr: Activate peergroup in address family

Open Monviech opened this issue 6 months ago • 1 comments

Fixes: https://github.com/opnsense/plugins/issues/4762

I asked OP to test, so lets wait first, but when looking at the frr documentation its indeed at the wrong spot.

Monviech avatar Jun 27 '25 12:06 Monviech

The examples do show neighbor .. activate inside the address-family block indeed, but as the name is actually an address, it should likely match the proper family. Haven't tried this on my end, but at a first glance it feels like we're missing something here.

AdSchellevis avatar Jun 28 '25 06:06 AdSchellevis

Right now its determined automatically by which networks exist in the bgp listen range.

But it's just an assumption. E.g., if you want the peer group only for IPv4 even though you have some IPv6 networks in the listen range, it should only activate for IPv4.

Maybe a dropdown inside the Peer Group for "IPv4", "IPv6", "IPv4 and IPv6" could make it better, as it lets the user decide?

In other news the user tested it and it solves it so we are on the right track.

Monviech avatar Jun 29 '25 10:06 Monviech

@Monviech can you document this in net/frr/pkg-descr?

fichtner avatar Jun 30 '25 11:06 fichtner

@fichtner Done

Monviech avatar Jun 30 '25 14:06 Monviech