os-bind include notify source parameters

[sebastian-muesch]

Hi everybody,

as I tried to figure out how to control the source-ip-address for notifies I would kindly request you to add two global parameters to the advanced general config. It would be quite simple ...

1. Add this to opnsense/mvc/app/models/OPNsense/Bind/General.xml after the querysourcev6 block

        <notifysource type="NetworkField">
            <AddressFamily>ipv4</AddressFamily>
            <NetMaskAllowed>N</NetMaskAllowed>
        </notifysource>
        <notifysourcev6 type="NetworkField">
            <AddressFamily>ipv6</AddressFamily>
            <NetMaskAllowed>N</NetMaskAllowed>
        </notifysourcev6>

2. Add this to opnsense/mvc/app/controllers/OPNsense/Bind/forms/general.xml after the querysourcev6 field

    <field>
        <id>general.notifysource</id>
        <label>Notify Source IP</label>
        <type>text</type>
        <advanced>true</advanced>
        <help>Specify the IPv4 address used as a source for outbound notifies.</help>
    </field>
    <field>
        <id>general.notifysourcev6</id>
        <label>Notify Source IPv6</label>
        <type>text</type>
        <advanced>true</advanced>
        <help>Specify the IPv6 address used as a source for outbound notifies.</help>
    </field>

3. Add this to opnsense/service/templates/OPNsense/Bind/named.conf after tehe config for querysourcev6

{% if helpers.exists('OPNsense.bind.general.notifysource') and OPNsense.bind.general.notifysource != '' %}
        notify-source {{ OPNsense.bind.general.notifysource }};
{% endif -%}

{% if helpers.exists('OPNsense.bind.general.notifysourcev6') and OPNsense.bind.general.notifysourcev6 != '' %}
        notify-source-v6 {{ OPNsense.bind.general.notifysourcev6 }};
{% endif -%}

I successfully tested it by manually patching the files on my 7 OPNsense instances.

[OPNsense-bot]

Thank you for creating an issue. Since the ticket doesn't seem to be using one of our templates, we're marking this issue as low priority until further notice.

For more information about the policies for this repository, please read https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md for further details.

The easiest option to gain traction is to close this ticket and open a new one using one of our templates.

[sopex]

Hello,

Why don't you just create a PR?

Best, sopex

[OPNsense-bot]

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository, please read https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue, just let us know, so we can reopen the issue and assign an owner to it.