Logging Severity incorrect - Acme Client Letsencrypt renew.

[bucker00]

• [X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• [X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

When a (Letsencrypt) certficate is renewed (successfully) by the ACME client the following is logged in System/Logfiles/General as such:

/usr/local/opnsense/scripts/OPNsense/AcmeClient/lecert.php: AcmeClient: The shell command returned exit code '0': '/usr/local/sbin/acme.sh --renew --syslog 7 --debug 3 --server 'letsencrypt' --dns 'dns_cf' ... However even though the return code was 0 and the certificate was renewed successfully the Severity of the event is marked as Error.

An event is logged immediately after with a severity of Notice and the text: AcmeClient: successfully issued/renewed certificate

To Reproduce

Steps to reproduce the behavior:

Issue or renew an existing certificate Go to System/Logfiles/General and the action will be logged as an error even when a successful renew occurred.

Expected behavior

I would have expected the Severity of this event to be Notice rather than Error.

Software & hardware:

OPNsense 24.1.6 (amd64). Intel(R) Core(TM) i3-10110U CPU @ 2.10GHz (2 cores, 4 threads) Protectli VP4630.