plugins icon indicating copy to clipboard operation
plugins copied to clipboard
verified publisher icon opnsense

www/nginx: 1.33

Open kulikov-a opened this issue 2 years ago • 6 comments

Hi! a few more suggestions )

  • Add the resolver directive support (closes https://github.com/opnsense/plugins/issues/3664)
  • Add config preview/test/copy to GUI
  • Add gzip disabling support (closes https://github.com/opnsense/plugins/issues/3245)
  • Move bot UA settings to GUI (closes https://github.com/opnsense/plugins/issues/2175)
  • Add auto-ban logging support (for better understanding/tuning/debugging)
  • Add Upstream keepalive support (https://www.nginx.com/blog/avoiding-top-10-nginx-configuration-mistakes/#no-keepalives) (closes https://github.com/opnsense/plugins/issues/3162)
  • Convert epoch time to readable format on Services: Nginx: Banned page
  • Cosmetic: add table header borders on Traffic Statistic page for better reading upd:
  • Add Stream proxy_connect_timeout and proxy_timeout directives support (closes https://github.com/opnsense/plugins/issues/3538)

Thanks! image

kulikov-a avatar Nov 18 '23 19:11 kulikov-a

@fabianfrz i removed .filter-option css rule (introduced in 1.32) to reflect core selectpicker update. image image

kulikov-a avatar Dec 15 '23 13:12 kulikov-a

@fabianfrz Thanks for the review! I'll try to take your suggestions asap. Sorry, I didn’t understand one thing: what do you mean by the need for translation in dialogues? upd. or you mean to translate '{{ lang._('Ok') }}' ? :smiley: (I'll proceed from this and update everything tomorrow)

kulikov-a avatar Dec 23 '23 07:12 kulikov-a

@kulikov-a yes, the label, the rest looks translated.

fabianfrz avatar Dec 23 '23 23:12 fabianfrz

@fabianfrz can you look one more time please ) hope I fixed everything. I chose the first variant of DOM-ready handler because I didn’t find such syntax in core code and I would like to follow the core style (I'll be happy to switch to ES6 as soon as I see this in core) same with the buttons - imho they are now where the user expects to see them, given the style of other pages. XSS possibility discussion: https://github.com/opnsense/plugins/pull/3678#discussion_r1435692098 thanks!

kulikov-a avatar Dec 24 '23 08:12 kulikov-a

@kulikov-a regarding ES6: The core was longer supporting IE than my plugins, because they never did (the nginx plugin was on ES6 since day one). So the core was always slower in adopting the new JavaScript syntax. Nowadays you can use ES6 features in core as well since IE is dead.

fabianfrz avatar Dec 27 '23 00:12 fabianfrz

@fabianfrz Thanks! I'll be happy to try using ES6 even for DOM-ready event on next PRs. Just trying to follow the product code style (waiting for such a notation to appear in the core or permission from @fichtner and @AdSchellevis)

kulikov-a avatar Dec 27 '23 08:12 kulikov-a

Merged, thanks!

fichtner avatar Jul 10 '24 08:07 fichtner

Thanks!!)

kulikov-a avatar Jul 10 '24 16:07 kulikov-a