core icon indicating copy to clipboard operation
core copied to clipboard

mvc: Decode HTML entities in user privileges, e.g. to not display `&`

Open Self-Hosting-Group opened this issue 7 months ago • 1 comments

Currently, user privileges (ACL) containing HTML entities are not decoded when displayed. This also affects the plugin, which is renamed by the following PR opnsense/plugins#4629. I also noticed that Dnsmasq DNS & DHCP circumvented the incorrect display by using a different character: https://github.com/opnsense/core/blob/4381fe4903ecbeff19ebd1e04b789628e51124ef/src/opnsense/mvc/app/models/OPNsense/Dnsmasq/ACL/ACL.xml#L3

This raises the question of whether user privileges should also be decoded when displayed, as with the menu items after a253e05.

Self-Hosting-Group avatar May 28 '25 13:05 Self-Hosting-Group

@AdSchellevis Ping the author of the menu item decoding commit

Self-Hosting-Group avatar May 28 '25 13:05 Self-Hosting-Group

Friendly ping.

Self-Hosting-Group avatar Oct 01 '25 13:10 Self-Hosting-Group

@Self-Hosting-Group https://github.com/opnsense/core/commit/e64b71d5af897db03ab7a3b07c429ee68fc1f2de should fix your issue.

AdSchellevis avatar Oct 02 '25 15:10 AdSchellevis

Thanks a lot! That was super quick!

Self-Hosting-Group avatar Oct 02 '25 15:10 Self-Hosting-Group

well, not that quick, but it wasn't at the top of my list yet ;)

AdSchellevis avatar Oct 02 '25 15:10 AdSchellevis

well, not that quick, but it wasn't at the top of my list yet ;)

I meant that seriously/positively because after the last ping, it really went quickly! I love open source devs!

Self-Hosting-Group avatar Oct 02 '25 15:10 Self-Hosting-Group