core icon indicating copy to clipboard operation
core copied to clipboard

Dnsmasq "Domain" / "Edit Domain Override" shall rename to "DNS Redirect" / "Edit DNS Redirect"

Open xatxhua opened this issue 7 months ago • 2 comments

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

  • [x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
  • [x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug The edit page menu "Edit Domain Override" is very mis-leading Currently entries in "Domain" tab will turn into "server=/example.com/1.1.1.1" --server= is actually a DNS redirect, not Domain Override. Domain Override (aka DNS override) is actually use --address= and/or --host-record= option.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Services --> Dnsmasq DNS & DHCP
  2. Click "Domain" Tab
    • Expect this rename to "DNS Redirect"
  3. Click on "+" / Add button
  4. See Title "Edit Domain Override"
    • Expect this rename to "Edit DNS Redirect"

Describe alternatives you considered Rename only view if MVC changes is too big? src/opnsense/mvc/app/views/OPNsense/Dnsmasq/settings.volt

Environment

OPNsense 25.1.7_2-amd64

xatxhua avatar May 24 '25 17:05 xatxhua

It's been named like this for over a decade (https://github.com/opnsense/core/blob/727453c076391c6891bf484eb8c9bac962d4803b/src/www/services_dnsmasq_domainoverride_edit.php), not sure it's worth the effort. If we would rename it, "query forwarding" is more inline with unbound as well.

AdSchellevis avatar May 24 '25 19:05 AdSchellevis

Agree, not worth the effort. Perhaps just add a simple description and example to the page will do: eg:

server=/*/1.1.1.1
server=/example.com/9.9.9.9
server=/foo.example.com/8.8.8.8
server=/bar.example.com/#

xatxhua avatar May 24 '25 20:05 xatxhua

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository, please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue, just let us know, so we can reopen the issue and assign an owner to it.

OPNsense-bot avatar Nov 20 '25 17:11 OPNsense-bot