Dnsmasq DHCP: allow option6 and option at the same time

[BPplays]

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• [x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• [x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.

i want to advertise domain-search over dhcpv6 and dhcpv4 but that would require me to add 2 dhcp option despite that fact they both represent the same thing

Describe the solution you like

allow option6 and option to be used at the same time and value gets used for both

Describe alternatives you considered

1. allow option6 and option to be used at the same time only for a whitelist of options that are the exact same e.g. dhcpv6 option 24 and dhcpv4 option 119

2. if option6 and option are selected turn value into value6 and value4, here are some ways that could work:

   1. hide value6 when no option6 is selected and hide value4 when no option is selected or
   2. if the user selected an option6 then added an option4 the the text in value is put into value6 and vice versa if option4 is selected first

[Monviech]

It sounds good in theory, but the reality is that the value for both options have different validations, e.g., option6 requires [] for IP values.

Tracking allowed combinations sounds like a larger mainatainance burden than just creating separate entries in my opinion.

[BPplays]

@Monviech maybe, but 2. in my alternatives is basically just the option to bundle an option and option6 as one item with 2 values (a value4 and a value6) so it's easier to keep track of options representing the same thing

edit: also for stuff like domain-search or tzdb-timezone i think it would work fine, most of the stuff you'd want shared wouldn't use IPs anyway

[AdSchellevis]

given all of this is quite new, I think we should park some of these requests until the actual value of certain changes is clearer. For consistency we could also just a add a toggle [ipv4/ipv6] and flip the visible field for clarity, which in some cases might even be better as it is more in line with other similar features.

[Monviech]

I kinda like that I do not have to toggle a different dropdown to reveal options or options6, as its one less step when configuring something.

Right now I would leave it as is and revisit it later.

[OPNsense-bot]

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository, please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue, just let us know, so we can reopen the issue and assign an owner to it.