core icon indicating copy to clipboard operation
core copied to clipboard

When Cloning a sprocket in opnsense's UI, the modal that's created retains the 'editing' title. leading to confusion

Open wolfspyre opened this issue 1 year ago • 0 comments

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

  • [ X ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
  • [ X ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug Concern is described in forum issue 41502

When a user clicks on 'clone $thing' (rule, server, alias, firewall rule, dhcp reservation, haproxy config, etc)

(AKA: 'pretty much anything that has a clone button')

The resulting modal popup has a title which conveys that the user is editing the original resource

Edit $resourcetype

rather than creating a new one from it.

This looks like its controlled by jquery, and the label seems like it would be targetable, thus if one clicks on 'clone' the title could read 'Clone $objectType' or 'Cloning $originalObjectTitle' rather than 'Edit $objectType'

While it's true, one is TECHNICALLY editing an item of that type, it's misleading, as the window appears the same as if one clicked the 'edit $thing' button...

To Reproduce

Steps to reproduce the behavior:

  1. Go to any opnsense page which has a list of elements which permit cloning
  2. Click on the clone button
  3. Get confused by the 'Editing $thing' title in the modal.

Expected behavior

Ideally the modal's title would read 'cloning $originalresource' or 'creating new $resourcetype from $original_item_cloned' or something.

Describe alternatives you considered

continuing to get confused.

regretting my life choices...

Screenshots

see forum post.

OPNsense 24.7 (amd64).

wolfspyre avatar Jul 12 '24 01:07 wolfspyre