core icon indicating copy to clipboard operation
core copied to clipboard

KEA: custom DNS for reservation #7310 - basic GUI and conf implementa…

Open Reiner030 opened this issue 1 year ago • 2 comments

…tion.

First implementation try for https://github.com/opnsense/core/issues/7310

NOT FOR PRODUCTION USAGE yet.

Basic GUI / conf implementation works "as usual" ... with several "copied" bugs where I am wondering where QA/community checks were failing to find this basic misbehavior yet since months:

  • if you copy entry similar to subnet definition with "Auto collect option data" unchecked the content of ALL option_data is GONE after save
  • if you check again "Auto collect option data" then you got still the option_data entries set previously (this commit can be yet the only "stable" one)

I was wondering why in subnet4 a dedicated "data-option" array was setup. Especially for "plain" CSV export/import and also "array dump to json" it doesn't make much sense. But maybe it's a workaround for the "not nested arrays implemented" code checks in which I trapped while trying to implement export/import CSV enhancments for reservations.

The import and exports handles modifies basic model templates so it must be used very carefully/checked against all other usages of this models. But I am not a PHP dev but more administrator with basic programming skills... ^^

Reiner030 avatar Jun 27 '24 14:06 Reiner030

if you copy entry similar to subnet definition with "Auto collect option data" unchecked the content of ALL option_data is GONE after save

https://github.com/opnsense/core/issues/7521

AdSchellevis avatar Jun 27 '24 15:06 AdSchellevis

Thanks for hint - wasn't checking last 3 weeks for updates of this problem. Just tested and also works for reservations fine like for subnet4.

Reiner030 avatar Jun 27 '24 18:06 Reiner030

timeout

AdSchellevis avatar Feb 12 '25 09:02 AdSchellevis