Kea DHCP HA "This server name" is overwritten on Opnsense HA update on slave

[roboticsalign]

trafficstars

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

• [ x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• [x ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

Opensense Version: OPNsense 24.1.6-amd64

New Kea DHCP comes with an HA-Option. A unique name must be given to identify master and slave. The name from the Opensense-Master is transferred to Opensense slave, when performing an status update. This setting should not be synchronized, because it breaks the HA-functionality of kea.

To Reproduce

Steps to reproduce the behavior:

1. Setup two opensense instances with ha
2. setup kea dhcp on both with ha and privide a unique server name to both servers
3. sync opnsense settings via "system" -> "ha" -> "status"
4. kea dhcp v4 -> "settings" -> "ha" -> "this server name" is synchronized
5. kea ha stops to work.

Expected behavior

There sould be an option to exclude the sync of the unique server-name.

Describe alternatives you considered

A clear and concise description of any alternative solutions or workaround you considered.

Additional context

Add any other context about the problem here.

[AdSchellevis]

as advertised, yes.

[roboticsalign]

Thanks for your response. I can't see any desired behavior here :

First, a unique name must not be synchronized 1:1 according to the meaning of unique. That never makes sense.

Second, the advice says, that the name of this machine will be used. According to the behavior and the description, it should also be synchronized by mistake.

In any case, in my opinion, both the behavior and the description should be adapted.

[AdSchellevis]

feel free to open a PR with suggestions, personally I believe the description is clear enough, but there's always room for improvements. Excluding sections from the HA sync or adding magic inside the sync is not planned and should not be needed either.