core icon indicating copy to clipboard operation
core copied to clipboard

Firewall rules no longer automatically created for IPSec

Open miken32 opened this issue 1 year ago • 2 comments

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

  • [x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
  • [x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug

When using the legacy IPSec connections, firewall rules are automatically created. This functionality has been removed with the new connections.

Describe alternatives you considered

If this functionality has been removed intentionally (or if it will take a while to implement) the label on "Disable all auto-added VPN rules." should be made clear that it only applies to legacy connections.

Additional context

It looks like this would need to be rewritten completely for new connection settings. I'm happy to help with a PR if it would be accepted, but would need some guidance where to start; maybe in OPNsense\IPsec\Api\ConnectionsController? How to access firewall, etc.

miken32 avatar Feb 14 '24 19:02 miken32

Wasn't sure to tag this as a feature request or not, since I don't know if it was taken out intentionally.

miken32 avatar Feb 14 '24 19:02 miken32

it's intentional, but having a switch to add simple rules shouldn't be an issue. We just like to prevent micro managing rules. If you want to give this a try, an example of such a feature can be found in this commit https://github.com/opnsense/core/commit/b1685d8e467d755fa1cf7203a82b63f2a115cb05

AdSchellevis avatar Feb 14 '24 20:02 AdSchellevis

This issue has been automatically timed-out (after 180 days of inactivity).

For more information about the policies for this repository, please read https://github.com/opnsense/core/blob/master/CONTRIBUTING.md for further details.

If someone wants to step up and work on this issue, just let us know, so we can reopen the issue and assign an owner to it.

OPNsense-bot avatar Aug 12 '24 18:08 OPNsense-bot