core icon indicating copy to clipboard operation
core copied to clipboard

Disabling hardware TCP segmentation offload doesn't disable VLAN_HWTSO

Open GeorgeH005 opened this issue 1 year ago • 1 comments

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

  • [x ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
  • [x ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug Disabling "hardware TCP segmentation offload" for the parent interface while leaving "Hardware VLAN Filtering" enabled does not disable VLAN_HWTSO

To Reproduce

  1. Disable TSO and LRO in the interface settings.
  2. Enable VLAN Hardware Filtering
  3. Check ifconfig options. VLAN_HWTSO should be included!

Expected behavior VLAN_HWTSO should have been disabled.

Describe alternatives you considered Disabling VLAN Hardware Filtering of course disables all related features, including the one in question. Setting net.inet.tcp.tso=0 should probably mitigate this, but I would like confirmation from someone more knowledgeable than me.

Additional Context

OPNSense is running in a VM in Proxmox but with the intel card passed through. SR-IOV is not being used.

Environment

OPNsense 23.7.11-amd64 FreeBSD 13.2-RELEASE-p7 Network Intel® I350-T2

GeorgeH005 avatar Jan 06 '24 14:01 GeorgeH005

same issue with me not recording at all

aabsharkhan avatar Nov 24 '22 09:11 aabsharkhan

https://user-images.githubusercontent.com/27461460/205488009-836f611b-70cc-47fd-afdd-feb4b27c5dcb.mp4

Could you kindly test the example app too? I couldn't reproduce this.

hyochan avatar Dec 04 '22 11:12 hyochan