core icon indicating copy to clipboard operation
core copied to clipboard

unbound: catch exception on blocklist reading

Open kulikov-a opened this issue 3 years ago • 0 comments

Hi! another thing noticed when trying to reproduce https://github.com/opnsense/core/issues/6026 if the connection or server is very (i made it 5 kbit/s) slow (and we also reduced the timeout value), the update may fail with a non-obvious Command ' /usr/local/opnsense/scripts/unbound/blocklists.py && /usr/local/opnsense/scripts/unbound/wrapper.py -b ' returned non-zero exit status 1 error in backend log. Perhaps it makes sense to catch exceptions when reading a file? Then a more understandable message like blocklist download : error reading file from https://blocklistproject.github.io/Lists/alt-version/malware-nl.txt (error : HTTPSConnectionPool(host='blocklistproject.github.io', port=443): Read timed out.) will get into the unbound log, and script execution will continue Thanks!

kulikov-a avatar Sep 19 '22 09:09 kulikov-a