core icon indicating copy to clipboard operation
core copied to clipboard

core/radvd Slightly Reorganise UI for disabling of DNS advertisements

Open pmhausen opened this issue 3 years ago • 0 comments

https://github.com/opnsense/core/issues/5919

pmhausen avatar Aug 02 '22 10:08 pmhausen

mind if I take this over?

fichtner avatar Aug 11 '22 12:08 fichtner

Not at all, go ahead. But please have at least a quick look at https://github.com/opnsense/plugins/issues/3070, too :)

pmhausen avatar Aug 11 '22 12:08 pmhausen

@pmhausen thanks, if you can please have a brief look at https://github.com/opnsense/core/commit/68894e989dc890954746507fe85cd4f5c087d94a to see if it makes sense (help texts)

Ok, I'll try to place the plugin issue in the appropriate queue.

fichtner avatar Aug 11 '22 12:08 fichtner

I find the wording "If a setting here is used the information below is ignored" a bit clumsy.

How about "If checked no DNS information is sent and the next setting concerning DHCPv6 is ignored."

pmhausen avatar Aug 11 '22 13:08 pmhausen

I tend to agree. The text, however, is trying to explain both settings at the same time. The below configuration is not DHCPv6 -- only the checkbox option above is.

fichtner avatar Aug 11 '22 13:08 fichtner

@pmhausen how about 1c322498c90 ? might be a little over the top but now the checkboxes do what the configuration actually does (disable other checkbox, hide custom dns options)

fichtner avatar Aug 12 '22 12:08 fichtner