core icon indicating copy to clipboard operation
core copied to clipboard

fix IntegerField minimum value

Open xbb opened this issue 2 years ago • 2 comments

Set the minimum value using PHP_INT_MIN which should be equal to -PHP_INT_MAX - 1

xbb avatar Jun 29 '22 21:06 xbb

I found the commit where this was introduced, there is a short conversation there which might add context to the reason why it was that way. https://github.com/opnsense/core/commit/06ff13943b3cddc378005bcd8995c105bb8057a0

agh1467 avatar Jul 07 '22 01:07 agh1467

I found the commit where this was introduced, there is a short conversation there which might add context to the reason why it was that way. 06ff139

I see, PHP_INT_MIN was introduced in PHP 7.0 and opnsense at that time was using, I think, PHP 5.6

xbb avatar Jul 07 '22 10:07 xbb

@xbb thanks!

AdSchellevis avatar Dec 21 '22 13:12 AdSchellevis