core icon indicating copy to clipboard operation
core copied to clipboard

Log: update severity level where appropriate

Open kulikov-a opened this issue 3 years ago • 4 comments

Hi! Continuation of https://github.com/opnsense/core/pull/5497 log_msg() sets LOG_WARNING by default as discussed at https://github.com/opnsense/core/commit/279de63e63129e0b6c94fcbf4b944674bc22a38d#comments change severity level where appropriate

Thanks!

kulikov-a avatar Feb 04 '22 15:02 kulikov-a

At a first glance I don't disagree on changing the levels for most of these messages, but I do want to prevent a large chunk of changes staying only on master for a longer period of time (as every release we're reviewing them).

If we can slip this (or a modified version) into a minor release, that would be my preference, I'll ask @fichtner what he thinks.

AdSchellevis avatar Feb 04 '22 15:02 AdSchellevis

Please let’s avoid the larger change before 1 months prior to 22.7. What we can do now is transform syslog() calls to log_msg() without those in config.inc

fichtner avatar Feb 04 '22 15:02 fichtner

@fichtner @AdSchellevis got it. should I close this or may I just convert to draft to remind myself?

kulikov-a avatar Feb 04 '22 15:02 kulikov-a

@kulikov-a draft is fine, thanks for your patience

AdSchellevis avatar Feb 04 '22 15:02 AdSchellevis

@kulikov-a if you can give this another try, see 931a851e09f 8b078c0ffd a7fd4381a2ee #5877 #6115

fichtner avatar Nov 04 '22 09:11 fichtner

Too much movement, I think we better close this.

fichtner avatar Nov 04 '22 12:11 fichtner

@fichtner Sure, I'll try to find some time )

kulikov-a avatar Nov 04 '22 13:11 kulikov-a