core icon indicating copy to clipboard operation
core copied to clipboard

Certificates/Trust: first step towards MVC for certificate management

Open 8191 opened this issue 2 years ago • 6 comments

Draft PR to indicate that something is going on in that direction. And maybe some first feedback if the change itself is desired.

Open points:

  • [ ] Legacy implementation also deletes all certificates of a CA when deleting the CA. I personally think that's not really desired and therefore did not implement this in this PR. ➡️ Requires final decision
  • [ ] It is (and also was in legacy impl.) possible to delete a CRL which is assigned to an OpenVPN server.
  • [ ] Intensive testing

8191 avatar Jan 17 '22 17:01 8191

I'm not against refactoring the Trust section, I'm just not sure we can spend enough time to make this happen short time. It might also be easier to start isolating the search functionality by the way so less code is being copied around, currently we are quite busy preparing for 22.1, but don't let me hold you from progressing this further.

AdSchellevis avatar Jan 17 '22 18:01 AdSchellevis

I'm just not sure we can spend enough time to make this happen short time

I didn't expect this to be merged any soon. It's a crucial functionality, so better longer testing than a broken PKI... 😀

Maybe a candidate for 22.7.

8191 avatar Jan 17 '22 19:01 8191

@AdSchellevis If you have time to look at this, just give me a hint upfront so that I can rebase onto the current master...

8191 avatar Mar 27 '22 11:03 8191

@8191 I'll keep it on the list, but given the amount of time needed to review and test this, it might take a while (it's not on the top of my priority list)

AdSchellevis avatar Mar 27 '22 11:03 AdSchellevis

Any news to this? I want to get access to certificates (and users) from the API. Looks that is planed for 23.7?

Marvo2011 avatar Mar 29 '23 10:03 Marvo2011

There is no plan.

fichtner avatar Mar 29 '23 10:03 fichtner