core icon indicating copy to clipboard operation
core copied to clipboard

IPsec public keys: provide generation function within GUI

Open 8191 opened this issue 3 years ago • 2 comments

Provide a "Generate" button in the IPsec RSA keys dialog to generate public/private keys: image

Proposals for a better/different user interface are welcome...

8191 avatar Jan 01 '22 19:01 8191

@8191 it might also be an option to only add a drop down "generate new key", which by default is set to no, otherwise is using the key size. In which case you can move the responsibility to the controller and keep the frontend implementation simpler.

AdSchellevis avatar Jan 02 '22 10:01 AdSchellevis

@AdSchellevis Thanks for the review, I've incorporated your comments.

Regarding the UI part: yes, having it in the controller might be better from a design point of view, but the downside is, that the user needs to reopen the already closed edit window to see the generated key (which he needs to distribute very likely).

8191 avatar Jan 04 '22 16:01 8191

https://github.com/opnsense/core/commit/e395da80b2f2f1d659413030bff6d1b0bcad4f05

AdSchellevis avatar Sep 29 '22 13:09 AdSchellevis