Robbert Langezaal

Results 50 comments of Robbert Langezaal

I forcefully removed the hook as such in `LmPluginUpdater.php` for now: ``` public function remove_class_action( $hook_name, $class_name, $method_name, $priority = 10 ) { global $wp_filter; if ( ! isset( $wp_filter[...

I tried the solution provided, unfortunately it is not working. I confirm that I have the latest composer package in my plugin. When I grep activator.activation_permanent I see it is...

I reverted back to setting an Array of $labels and adding it to the configuration. If I change the code in Configuration.php constructor like so: ``` $this->setupLabels(); //add_action('init', [$this, 'setupLabels']);...

Oh my, I remember reading you implemented a request to support that Ansi code. I didnt put 1+1 together. So sorry to mention this as a issue while its caused...

Yeah, full screen fTelnet without F11 is really pleasant to the eye. After examining the issue, googling for answers and some chatgpt (kuch) help this should indeed be a general...

Mhm I just tested the code and it isnt working-- let me fix this myself and I will report back.

Alright, I fixed the intial selected character by adjusthing the following line. The starting point of selection is perfect. https://github.com/rickparrish/fTelnet/blob/9dbbd71c3dfb12edf07bf8bea29a5b7eed4f6fd9/source/crt/Crt.ts#L1050 To: ``` //this._MouseDownPoint = this.MousePositionToScreenPosition(me.offsetX, me.offsetY); const rect = this._Canvas.getBoundingClientRect();...

Ah, I had to update this line too (OnMouseMove): https://github.com/rickparrish/fTelnet/blob/9dbbd71c3dfb12edf07bf8bea29a5b7eed4f6fd9/source/crt/Crt.ts#L1083 ``` //NewMovePoint = this.MousePositionToScreenPosition(me.offsetX, me.offsetY); const rect = this._Canvas.getBoundingClientRect(); const scaleX = this._Canvas.width / rect.width; const scaleY = this._Canvas.height /...

Oh, if this code gets added, it also fixes getting incorrect coordinate ANSI codes. Big win for my small next projects!

I notice I also added the code to OnMouseUp event. Just to be sure the right coordinate gets send. I did not list that part of the code above.