openproject
openproject copied to clipboard
Move @types/* to devDependencies
Ticket
n/a
What are you trying to accomplish?
Moves typings to devDependencies in package.json
What approach did you choose and why?
n/a
Merge checklist
- [ ] Added/updated tests
- [ ] Added/updated documentation in Lookbook (patterns, previews, etc)
- [ ] Tested major browsers (Chrome, Firefox, Edge, ...)
FYI in the past, this always caused issues as devDeps should strictly be used for testing dependencies, not those required for buildtime. But as this happened too often, the buildpack was used with NPM_CONFIG_PRODUCTION=false https://github.com/opf/openproject/blob/d309279c4c37989a93b0bad83d2a25079d4f7876/.pkgr.yml#L55 in order not to prune devDependencies.
I would argue the types are an actual dependency, as we require it for building. In the end, it's not extremly important, as we are not packaging a library.