openproject Freeze string literals in the meetings module

Achieved through

rubocop -A --only Style/FrozenStringLiteralComment,Layout/EmptyLineAfterMagicComment,Style/RedundantFreeze modules/meeting

Part of freezing string literals across the application step-by-step to be well prepared for future Ruby releases.

May 12 '25 07:05 NobodysNightmare

1 Warning

:warning: Attention developer & reviewer: Files with potential user references found:

modules/meeting/db/migrate/20230816141222_create_meeting_agenda_items.rb (migration with user reference)

modules/meeting/db/migrate/20240313102951_add_presenter_to_meeting.rb (migration with user reference)

modules/meeting/db/migrate/20240426073948_create_recurring_meetings.rb (migration with user reference)

Please make sure:

You've added proper relationships (has_many, belongs_to, …) and their inverse in your models

You deal with model destruction dependencies: dependent: :destroy or dependent: :delete_all

You add behavior and tests for the Principal::DeleteJob (app/workers/principals/delete_job.rb)

You replace references to users with deleted user in Principal::ReplaceReferencesService (app/services/principals/replace_references_service.rb) by adding to the replacements initailizer (config/initializers/replace_references_service.rb) for the core, or using the replace_principal_references helper in modules/plugins.

You test the above behaviors with an integration test (e.g., like this one to confirm deletion of users is possible.

This helps prevent dangling database objects when users are deleted and resulting bugs.

	1 Warning
:warning:	Attention developer & reviewer: Files with potential user references found: modules/meeting/db/migrate/20230816141222_create_meeting_agenda_items.rb (migration with user reference) modules/meeting/db/migrate/20240313102951_add_presenter_to_meeting.rb (migration with user reference) modules/meeting/db/migrate/20240426073948_create_recurring_meetings.rb (migration with user reference) Please make sure: You've added proper relationships (has_many, belongs_to, …) and their inverse in your models You deal with model destruction dependencies: `dependent: :destroy` or `dependent: :delete_all` You add behavior and tests for the Principal::DeleteJob (app/workers/principals/delete_job.rb) You replace references to users with deleted user in Principal::ReplaceReferencesService (app/services/principals/replace_references_service.rb) by adding to the replacements initailizer (config/initializers/replace_references_service.rb) for the core, or using the `replace_principal_references` helper in modules/plugins. You test the above behaviors with an integration test (e.g., like this one to confirm deletion of users is possible. This helps prevent dangling database objects when users are deleted and resulting bugs.

Generated by :no_entry_sign: Danger

May 12 '25 07:05 github-actions[bot]

I only see whitespace changes (i.e. Layout/EmptyLineAfterMagicComment fixes)

May 16 '25 12:05 myabc

You are right. Apparently there is no missing frozen string literals left. The only thing that was fixed is the whitespace after the magic comment and a few double freezes (RedundantFreeze).

So it's not only whitespace, but much less than I expected when I copy-pasted the PR description ^^

May 16 '25 12:05 NobodysNightmare