openproject icon indicating copy to clipboard operation
openproject copied to clipboard

No need right padding as spot-icon_dropdown takes 24px already.

Open Eric-Guo opened this issue 1 year ago • 4 comments

The purpose of PR is remove extra right padding for toolbar button Create, Include projects, Baseline and Filter, so given more space for query name.

Before:

Old-EN_2024-07-12_11 13 36 Old-CN_2024-07-12_11 13 08

After:

New-EN_2024-07-12_11 11 31 New-CN_2024-07-12_11 10 14

Eric-Guo avatar Jul 12 '24 03:07 Eric-Guo

That buttons look rather squeezed to me..

Actually it's same as previous design of wp-fold-toggle-button (before this PR), which icon-pulldown have no padding:

iShot_2024-07-19_10 01 01 iShot_2024-07-19_10 03 00

So this PR is just make sure there is no extra padding for other icon-pulldown:

iShot_2024-07-19_10 02 05

Eric-Guo avatar Jul 19 '24 02:07 Eric-Guo

Hi @Eric-Guo

I still think that instead of pushing the last bits out of the buttons we should rather let the whole toolbar wrap much earlier. With the amount of buttons that we have there now, we have to accept that the buttons have to move to a new line if there is not enough space. Maybe a min-width for the title would already do the trick.

HDinger avatar Jul 19 '24 06:07 HDinger

i think both can be bone, that padding on the dropdown icons really is unnecessary, and we could use two logic for the toolbar wrap, one just for the view size, and the other if the text needs to be shortened to fit

piradata avatar Nov 29 '24 18:11 piradata

i think both can be bone, that padding on the dropdown icons really is unnecessary, and we could use two logic for the toolbar wrap, one just for the view size, and the other if the text needs to be shortened to fit

piradata avatar Nov 29 '24 18:11 piradata