openproject icon indicating copy to clipboard operation
openproject copied to clipboard
Published 3 months ago • verified publisher icon opf

Pass ssl_verification value to the NET-IMAP library

Open fduraibi opened this issue 3 years ago • 1 comments

The current implementation sets the verify_mode based on the ssl_verification value and doesn't pass the value to the library "net-imap", which sets the variable verify to the default value true.

However, in net-imap library the verify_mode is set/reset inside the create_ssl_params function based on the value of verify which is set to true as a default value.

My fix is not to set the value for verify_mode and instead pass ssl_verification to the net-imap library which handles the settings correctly. I also removed the ssl_option function since there is no need for it.

fduraibi avatar Sep 15 '22 11:09 fduraibi

Hi @fduraibi , thanks for your submission. I'll look into it and let you know.

oliverguenther avatar Sep 15 '22 17:09 oliverguenther

Sorry for the late reply. This got applied to dev in https://github.com/opf/openproject/commit/890125e0c9 Thanks for looking into this :+1:

oliverguenther avatar Dec 12 '22 15:12 oliverguenther